Conversation
|
|
||
| ### 4. Check `@agentclientprotocol/sdk` version compatibility | ||
|
|
||
| The `@aaif/goose-acp` package declares `@agentclientprotocol/sdk` as a **peer dependency** (`"*"`). The Rust backend currently uses `agent-client-protocol = "0.10.4"`. The TypeScript SDK should be at a compatible version. |
There was a problem hiding this comment.
this is interesting. i thought i did a refactor such that it fully wraps the @agentclientprotocol/sdk interactions all inside GooseClient
maybe I/we mistakenly left it as a peer dep?
| ### 8. `listProviders` | ||
|
|
||
| ```typescript | ||
| const DEPRECATED_PROVIDER_IDS = new Set(["claude-code", "codex", "gemini-cli"]); |
There was a problem hiding this comment.
straight from the tauri layer:
(not that that explains much)
There was a problem hiding this comment.
we should clear this up. I think the idea here is that these are or could be ACP providers, so you'd connect to them directly rather than connecting through the goose provider layer ?
|
|
||
| ## Objective | ||
|
|
||
| Replace all `invoke()` calls in `src/shared/api/acp.ts` with calls to the new TypeScript ACP session manager (Step 05) and search module (Step 06). Keep the same public API signatures so consumers don't need to change. |
There was a problem hiding this comment.
I would have it just eliminate this layer of abstraction in this step and hook the things that called it up directly to the new thing
| } | ||
| ``` | ||
|
|
||
| Wait — adding `reqwest` is a new dependency. A simpler approach: use `tokio::net::TcpStream::connect` to check if the port is open: |
There was a problem hiding this comment.
You might regen this file to be more to the point of using one approach
|
|
||
| | Method | Request | Response | | ||
| |--------|---------|----------| | ||
| | `goose/config/get` | `{ key: string }` | `{ value: string \| null }` | |
There was a problem hiding this comment.
these method prefixes will need _goose right?
|
|
||
| This is the trickiest subsystem because it involves **interactive shell commands with streaming output**. The current Rust code spawns a child process and streams stdout/stderr lines as Tauri events (`agent-setup:output`, `model-setup:output`). | ||
|
|
||
| #### Options |
There was a problem hiding this comment.
I would re-gen this file with one perspective on what the best approach is
3 participants
A (work in progress) plan for ACP-plus adoption in goose2