-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Replace ensure-local-goose #8532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
07e55ac
f78b46a
3aa7136
347cc13
3029338
2e0aa82
760e99e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| # Default recipe | ||
| default: | ||
| @just --list | ||
| import '../../Justfile' | ||
|
|
||
| # ── Dev Environment ────────────────────────────────────────── | ||
|
|
||
|
|
@@ -70,10 +68,14 @@ test-e2e-all: | |
| # ── Run ────────────────────────────────────────────────────── | ||
|
|
||
| # Start the desktop app in dev mode | ||
| dev: | ||
| dev: build-debug | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| if [[ -z "${GOOSE_BIN:-}" ]]; then | ||
| export GOOSE_BIN="$(cargo metadata --format-version 1 | jq -r '.target_directory')/debug/goose" | ||
|
jamadeo marked this conversation as resolved.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new default Useful? React with 👍 / 👎. |
||
| fi | ||
|
|
||
| # Derive a stable port from the working directory so the same worktree | ||
| # always gets the same port. This avoids changing TAURI_CONFIG between | ||
| # runs, which would invalidate Cargo's build cache and trigger a full | ||
|
|
@@ -104,10 +106,14 @@ dev: | |
| pnpm tauri dev --features app-test-driver --config "$TAURI_CONFIG" | ||
|
|
||
| # Start the desktop app with dev config | ||
| dev-debug: | ||
| dev-debug: build-debug | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| if [[ -z "${GOOSE_BIN:-}" ]]; then | ||
| export GOOSE_BIN="$(cargo metadata --format-version 1 | jq -r '.target_directory')/debug/goose" | ||
| fi | ||
|
|
||
| VITE_PORT=$(python3 -c "import hashlib,os; h=int(hashlib.sha256(os.getcwd().encode()).hexdigest(),16); print(10000 + h % 55000)") | ||
| export VITE_PORT | ||
| EXTRA_CONFIG="--config {\"build\":{\"devUrl\":\"http://localhost:${VITE_PORT}\",\"beforeDevCommand\":{\"script\":\"exec ./node_modules/.bin/vite --port ${VITE_PORT} --strictPort\",\"cwd\":\"..\",\"wait\":false}}}" | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing
../../Justfilehere creates a cycle because the rootJustfilealready declaresmod goose2 'ui/goose2'; loading either file now requires loading the other again. In practice this preventsjustfrom loading recipes (e.g.,just dev/just goose2::dev) until the cycle is broken, so local dev commands become unusable.Useful? React with 👍 / 👎.