Skip to content

Add blob count to image pull progress display #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add blob count to image pull progress display #15

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10a3315
Initial plan
Copilot Jan 8, 2026
3adee09
Add layer count to image pull progress display
Copilot Jan 8, 2026
e1f9bed
Use 'blobs' instead of 'layers' for more accurate terminology
Copilot Jan 8, 2026
f41e9a2
Add documentation for countBlobs function
Copilot Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions cmd/ctr/commands/images/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,13 +388,14 @@ func ProgressHandler(ctx context.Context, out io.Writer) (transfer.ProgressFunc,

func DisplayHierarchy(w io.Writer, status string, roots []*progressNode, start time.Time) {
total := displayNode(w, "", roots)
blobCount := countBlobs(roots)
for _, r := range roots {
if desc := r.mainDesc(); desc != nil {
fmt.Fprintf(w, "%s %s\n", desc.MediaType, desc.Digest)
}
}
// Print the Status line
fmt.Fprintf(w, "%s\telapsed: %-4.1fs\ttotal: %7.6v\t(%v)\t\n",
fmt.Fprintf(w, "%s\telapsed: %-4.1fs\ttotal: %7.6v\t(%v)\tblobs: %d\t\n",
status,
time.Since(start).Seconds(),
// TODO(stevvooe): These calculations are actually way off.
Expand All @@ -403,7 +404,19 @@ func DisplayHierarchy(w io.Writer, status string, roots []*progressNode, start t
// but will be skewed if restarting, as it includes the
// data into the start time before.
progress.Bytes(total),
progress.NewBytesPerSecond(total, time.Since(start)))
progress.NewBytesPerSecond(total, time.Since(start)),
blobCount)
}

// countBlobs recursively counts all progress nodes in the tree, including
// manifests, configs, and layers.
func countBlobs(nodes []*progressNode) int {
count := 0
for _, node := range nodes {
count++
count += countBlobs(node.children)
}
return count
}

func displayNode(w io.Writer, prefix string, nodes []*progressNode) int64 {
Expand Down