Merge pull request #788 from bordeo/master

Correct AMD define for plugins
aFarkas · May 25, 2020 · 83f8871 · 83f8871
2 parents eee2d40 + 6652d3a
commit 83f8871
Show file tree

Hide file tree

Showing 48 changed files with 51 additions and 47 deletions.
diff --git a/README.md b/README.md
@@ -498,6 +498,10 @@ lazySizes.init();
 
 ## Contributing
 Fixes, PRs and issues are always welcome, make sure to create a new branch from the **master** (not the gh-pages branch), validate against JSHint and test in all browsers. In case of an API/documentation change make sure to also document it here in the readme.md.
+### Build
+Run `npx grunt` to validate JSHint and uglify/minify all files.
+### Tests
+Run `npx serverino -p 3333` and navigate to [http://localhost:3333/tests/](http://localhost:3333/tests/)
 
 ## <a name="plugins"></a>Available plugins in this repo
 It is recommended to concat all plugins together with lazySizes. In case you don't concat it is recommended to include the plugin scripts *before* the lazySizes main script.

diff --git a/plugins/artdirect/ls.artdirect.js b/plugins/artdirect/ls.artdirect.js
@@ -10,7 +10,7 @@
 	if(typeof module == 'object' && module.exports){
 		factory(require('lazysizes'));
 	} else if (typeof define == 'function' && define.amd) {
-		require(['lazysizes'], factory);
+		define(['lazysizes'], factory);
 	} else if(window.lazySizes) {
 		globalInstall();
 	} else {

diff --git a/plugins/artdirect/ls.artdirect.min.js b/plugins/artdirect/ls.artdirect.min.js
diff --git a/plugins/aspectratio/ls.aspectratio.js b/plugins/aspectratio/ls.aspectratio.js
@@ -9,7 +9,7 @@
 	if(typeof module == 'object' && module.exports){
 		factory(require('lazysizes'));
 	} else if (typeof define == 'function' && define.amd) {
-		require(['lazysizes'], factory);
+		define(['lazysizes'], factory);
 	} else if(window.lazySizes) {
 		globalInstall();
 	} else {

diff --git a/plugins/aspectratio/ls.aspectratio.min.js b/plugins/aspectratio/ls.aspectratio.min.js
diff --git a/plugins/attrchange/ls.attrchange.js b/plugins/attrchange/ls.attrchange.js
@@ -10,7 +10,7 @@
 	if(typeof module == 'object' && module.exports){
 		factory(require('lazysizes'));
 	} else if (typeof define == 'function' && define.amd) {
-		require(['lazysizes'], factory);
+		define(['lazysizes'], factory);
 	} else if(window.lazySizes) {
 		globalInstall();
 	} else {

diff --git a/plugins/attrchange/ls.attrchange.min.js b/plugins/attrchange/ls.attrchange.min.js
diff --git a/plugins/bgset/ls.bgset.js b/plugins/bgset/ls.bgset.js
@@ -9,7 +9,7 @@
 	if(typeof module == 'object' && module.exports){
 		factory(require('lazysizes'));
 	} else if (typeof define == 'function' && define.amd) {
-		require(['lazysizes'], factory);
+		define(['lazysizes'], factory);
 	} else if(window.lazySizes) {
 		globalInstall();
 	} else {