-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ci(dart): analyze, format and test the packages under dart/ #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+110
−6
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
299cc99
style(dart): resolve the bare library directives
diegolopezrm 5ab01cc
ci(dart): analyze, format and test the packages under dart/
diegolopezrm 9e71eb2
Merge remote-tracking branch 'upstream/main' into ci-dart-packages
diegolopezrm 066da15
style(dart): format two test files the new CI job would reject
diegolopezrm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Analyzes, formats and tests the pure Dart packages under dart/. | ||
| # | ||
| # The Flutter workflow builds its matrix from samples/, so the packages that | ||
| # ship to pub.dev were not covered by any job. This workflow holds them to the | ||
| # same bar the samples are held to: formatting, analysis with --fatal-infos, | ||
| # and the package's own tests. | ||
| name: Dart CI | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref_name || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| matrix: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| matrix: ${{ steps.generate_matrix.outputs.matrix }} | ||
| steps: | ||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Generate testing matrix | ||
| id: generate_matrix | ||
| run: | | ||
| DIRS_TO_TEST=$(find dart -name pubspec.yaml -not -path "*/.dart_tool/*" -exec dirname {} \;) | ||
|
|
||
| JSON_MATRIX="[" | ||
| FIRST=true | ||
| for dir in $DIRS_TO_TEST; do | ||
| if [ "$FIRST" = false ]; then | ||
| JSON_MATRIX="$JSON_MATRIX," | ||
| fi | ||
| FIRST=false | ||
| package_name=$(echo "$dir" | tr '/' '_') | ||
| JSON_MATRIX="$JSON_MATRIX{\"name\":\"$package_name\",\"path\":\"$dir\"}" | ||
| done | ||
| JSON_MATRIX="$JSON_MATRIX]" | ||
|
|
||
| echo "matrix=$JSON_MATRIX" >> $GITHUB_OUTPUT | ||
|
|
||
| analyze_and_test: | ||
| needs: matrix | ||
| name: ${{ matrix.package.name }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| package: ${{ fromJson(needs.matrix.outputs.matrix) }} | ||
| steps: | ||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| # The packages resolve through the monorepo workspace, whose root pubspec | ||
| # declares a Flutter SDK constraint, so a Dart-only SDK cannot resolve | ||
| # them. See https://github.com/a2ui-project/a2ui/issues/2463. | ||
| - uses: ./.github/actions/setup-dart | ||
|
|
||
| - name: Install dependencies | ||
| working-directory: ${{ matrix.package.path }} | ||
| run: dart pub get | ||
|
|
||
| - name: Check formatting | ||
| working-directory: ${{ matrix.package.path }} | ||
| run: dart format --output=none --set-exit-if-changed . | ||
|
|
||
| - name: Analyze code | ||
| working-directory: ${{ matrix.package.path }} | ||
| run: dart analyze --fatal-infos | ||
|
|
||
| - name: Run tests | ||
| working-directory: ${{ matrix.package.path }} | ||
| run: dart test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will skip dart files in other parts of the tree. There currently aren't any, but that doesn't mean there couldn't be (imagine a tool implemented in Dart, for instance), and it is a monorepo, so the top level directory is also excluded by this. I'd search the whole tree.