Allow for empty properties in dotnet msbuild

Fixes cake-build#4158
Zulu-Inuoe · Jun 4, 2023 · 5301bb4 · 5301bb4
1 parent b55239f
commit 5301bb4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs b/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs
@@ -55,11 +55,6 @@ public static void AppendMSBuildSettings(this ProcessArgumentBuilder builder, Do
             // Got any properties?
             foreach (var property in settings.Properties)
             {
-                if (property.Value == null || property.Value.All(string.IsNullOrWhiteSpace))
-                {
-                    throw new ArgumentException("A property must have at least one non-empty value", nameof(settings.Properties));
-                }
-
                 msBuilder.AppendMSBuildSwitch("property", $"{property.Key}={property.BuildMSBuildPropertyParameterString()}");
             }
 

diff --git a/tests/integration/Cake.Common/Tools/DotNet/DotNetAliases.cake b/tests/integration/Cake.Common/Tools/DotNet/DotNetAliases.cake
@@ -223,6 +223,26 @@ Task("Cake.Common.Tools.DotNet.DotNetAliases.DotNetMSBuild")
     Assert.True(System.IO.File.Exists(assembly.FullPath));
 });
 
+Task("Cake.Common.Tools.DotNet.DotNetAliases.DotNetMSBuildEmptyParametersAllowed")
+    .IsDependentOn("Cake.Common.Tools.DotNet.DotNetAliases.DotNetClean")
+    .Does(() =>
+{
+    // Given
+    var path = Paths.Temp.Combine("./Cake.Common/Tools/DotNet");
+    var project = path.CombineWithFilePath("hwapp/hwapp.csproj");
+    var assembly = path.CombineWithFilePath("hwapp/bin/Debug/net7.0/hwapp.dll");
+
+    // When
+    DotNetMSBuild(project.FullPath, new DotNetBuildSettings() {
+        MSBuildSettings = new DotNetMSBuildSettings(){
+        }
+        .WithProperty("APropertyIWantTobeBlank", "")
+    });
+
+    // Then
+    Assert.True(true);
+});
+
 Task("Cake.Common.Tools.DotNet.DotNetAliases.DotNetTest.Fail")
     .IsDependentOn("Cake.Common.Tools.DotNet.DotNetAliases.DotNetTest")
     .Does(() =>