Skip to content

[Fix] Subtask approval E2E times out after task restoration #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelauna merged 2 commits into from
Aug 29, 2026
Merged

[Fix] Subtask approval E2E times out after task restoration #1434

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993ebd9
test(e2e): await subtask approval restoration
roomote Aug 29, 2026
165ea60
lint(e2e): reject floating promises
roomote Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/vscode-e2e/src/suite/subtasks.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ suite("Roo Code Subtasks", function () {
const parentAskCount = asks[parentTaskId]?.length ?? 0

await api.clearCurrentTask()
api.resumeTask(parentTaskId)
await api.resumeTask(parentTaskId)
await waitFor(() => hasToolAsk(parentTaskId, "newTask", parentAskCount))
assert.ok(
!asks[parentTaskId]?.slice(parentAskCount).some(({ ask }) => ask === "resume_task"),
Expand All @@ -235,7 +235,7 @@ suite("Roo Code Subtasks", function () {
const childAskCount = asks[childTaskId!]?.length ?? 0

await api.clearCurrentTask()
api.resumeTask(childTaskId!)
await api.resumeTask(childTaskId!)
await waitFor(() => hasToolAsk(childTaskId!, "finishTask", childAskCount))
assert.ok(
!asks[childTaskId!]
Expand Down
Loading