Export switch subtext setter #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
requested changes
Jan 2, 2025
app/ui/view_nbgl.c
Outdated
| @@ -292,7 +278,9 @@ static void settings_screen_callback(uint8_t index, nbgl_content_t *content) { | |||
| #ifdef APP_BLINDSIGN_MODE_ENABLED | |||
| switches[BLINDSIGN_MODE].initState = app_mode_blindsign(); | |||
| switches[BLINDSIGN_MODE].text = "Blind sign"; | |||
| switches[BLINDSIGN_MODE].subText = ""; | |||
| if ((switches[BLINDSIGN_MODE].subText) == NULL) { | |||
| switches[BLINDSIGN_MODE].subText = "Allows signing transactions without seeing all fields"; | |||
There was a problem hiding this comment.
Is there enough space to display this on flex/stax? instead of "seeing", maybe "reviewing"? Otherwise, let's ask AI what it thinks about this description haha.
emmanuelm41
approved these changes
Jan 7, 2025
0xPxt
force-pushed
the
view_set_switch_subtext
branch
from
5e317d3 to
22bc419
Compare
neithanmo
approved these changes
Jan 7, 2025
0xPxt
force-pushed
the
view_set_switch_subtext
branch
from
22bc419 to
35dc757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view_set_switch_subtextso that any app can modify the subtext of a switch according to its needs.🔗 zboto Link