Add HTS221 sensor driver (temperature only) #746
Conversation
Grazfather
changed the title
|
|
||
| // Simpler version of MMIO to ease register setting. | ||
| // I guess this would be a nice abstraction to have in the framework base | ||
| fn Reg(comptime PackedT: type) type { |
There was a problem hiding this comment.
Yeah this could be moved somewhere. If you move it we should file an issue to update other drivers to use it.
| fn setup_average(self: *@This(), avgt: AVGT, avgh: AVGH) !void { | ||
| try self.dev.write_then_read(address, &[_]u8{RegsAddr.AV_CONF.v()}, self.read_buffer[0..1]); | ||
| var reg = AV_CONF.from(self.read_buffer[0]); | ||
| reg.modify(.{ |
There was a problem hiding this comment.
This is the only time you actually set more than one field with modify. We can probably just use simple structs, maybe an extra PR to add this reg type
There was a problem hiding this comment.
I would suggest for consistency to always use the Regs abstraction. Even when the solution could be accomplish with struct alone. (It also hide those bitCast). Wdyt?
| microzig.board.init_log(); | ||
| } | ||
|
|
||
| pub noinline fn main() !void { |
There was a problem hiding this comment.
what was the inline issue? Do we need to fix other examples?
There was a problem hiding this comment.
The issue is due to the FPU. and release mode. If the main is inline into microzig_main the function will start with some vpush instruction before you can enable fpu which rise a fault. I guess a better approach would be to enable FPU at the very beginning and even maybe decide that at build time with some options.
2 participants
No description provided.