Flash driver interface #589
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we can put more specific interfaces not under base but under a flash namespace (in this case)? |
|
Looks like the rebase fixed the linter errors.
I don't have a strong opinion about location in the tree, but I'm also not sure what level of abstraction is appropriate. It's labeled "flash" right now, and the main goal when writing it was a basic, consistent interface to MCU internal flash since I was working on a bootloader, but it could really represent just about any nonvolatile memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the start of a driver interface for flash memory, modeled roughly on the datagram device. Right now I'm implementing it as erasing/writing sectors only, and reading at an arbitrary offset.
I'm open to some bikeshedding on this, I think it mostly does what I was after when I wrote it, but it's definitely incomplete from a library perspective.