Skip to content

Fixes to interrupt handling #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Uthedris
Copy link
Contributor

Fixes:

  • riscv32_common.zig is_pending function need a compare to return a bool.
  • hazard3.zig interrupt priority registers were incorrect.
  • hazard3.zig removed an interrupt enable that tact1m4n3 didn't like.

@Grazfather Grazfather requested a review from tact1m4n3 May 24, 2025 18:17
Copy link
Collaborator

@tact1m4n3 tact1m4n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Don't know why I used meifa to set priorities 😆. Also, some riscv examples are broken, please change the examples using external interrupts to enable the MachineExternal interrupt on riscv.

@Uthedris
Copy link
Contributor Author

I updated the interrupt example. The only other examples I found that used interrupts were RP2040 only, so don't need riscv support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants