-
Notifications
You must be signed in to change notification settings - Fork 131
nRF5x: Add i2c hal + datagram device #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
}); | ||
} | ||
|
||
/// Disables I2C, returns peripheral registers to reset state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true. Is this true on the rp2xxx? If so, I'd expect set_address in that hal to cause issues.
28d9f2f
to
dbe79e9
Compare
@@ -195,6 +195,7 @@ test "i2c.translate_baudrate" { | |||
try std.testing.expectError(ConfigError.InputFreqTooLow, translate_baudrate(1_000_000, 31_900_000)); | |||
} | |||
|
|||
// TODO: Why create this empty struct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove this, but I am wondering why we do this. My hal does not. I don't think it's necessary?
This adds a HAL for the i2c master peripheral on the nRF5x, both for the byte-banged and the DMA version.
It adds an example of a bus scan and reading from a TMP117 temperature scanner, both using both HALs