nRF5x: Add i2c hal + datagram device #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
commented
May 23, 2025
Grazfather
commented
May 23, 2025
| }); | ||
| } | ||
|
|
||
| /// Disables I2C, returns peripheral registers to reset state. |
There was a problem hiding this comment.
not true. Is this true on the rp2xxx? If so, I'd expect set_address in that hal to cause issues.
Grazfather
force-pushed
the
nrf-hal-i2c
branch
3 times, most recently
from
28d9f2f to
dbe79e9
Compare
Grazfather
commented
May 24, 2025
| @@ -195,6 +195,7 @@ test "i2c.translate_baudrate" { | |||
| try std.testing.expectError(ConfigError.InputFreqTooLow, translate_baudrate(1_000_000, 31_900_000)); | |||
| } | |||
|
|
|||
| // TODO: Why create this empty struct? | |||
There was a problem hiding this comment.
I will remove this, but I am wondering why we do this. My hal does not. I don't think it's necessary?
mattnite
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a HAL for the i2c master peripheral on the nRF5x, both for the byte-banged and the DMA version.
It adds an example of a bus scan and reading from a TMP117 temperature scanner, both using both HALs