rp2350: Fix GlobalConfig for uart, rename func to match rp2040 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for consistency with rp2040
Grazfather
changed the title
Grazfather
commented
Mar 8, 2025
Grazfather
commented
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RP2350 adds an extra value for
FUNCSELfor the GPIOs. This value, for some GPIOs, is a second uart use. We named the first.uart_firstand the second.uart_second.This naming made it so that we had to select either
.uart(on rp2040) or.uart_first(on rp2350), which made the code messier than it needed to be.Additionally, if using the
GlobalConfigurationwith a gpio set to a uart function, it would not work since our code naively set it to.uart, which didn't exist on rp2350.Making the name the same for the functionality fixes the GlobalConfiguration.
Additionally, I cleaned up a bunch of examples and tested them on rp2350. The ones that work, I moved to the chip-agnostic-examples.
The GlobalConfiguration still will not work if trying to set a pin for a function that needs the FUNCSEL set to the second uart functionality. That can be done in a follow up, and I added TODOs appropriately.