fix: match upstream OnPlayerResurrect signature (bool& applySickness)#63
Open
SI-ChrisL wants to merge 1 commit into
Open
fix: match upstream OnPlayerResurrect signature (bool& applySickness)#63SI-ChrisL wants to merge 1 commit into
SI-ChrisL wants to merge 1 commit into
Conversation
AzerothCore's PlayerScript::OnPlayerResurrect declares the third parameter as `bool& applySickness` (pass-by-reference). This module's overrides used `bool applySickness` (pass-by-value), so the signatures didn't match and the `override` specifier silently failed to bind to the virtual base — meaning the hook never actually fired for Hardcore or Iron Man challenge modes. Update both ChallengeMode_Hardcore and ChallengeMode_IronMan to take the parameter by reference, matching ScriptDefines/PlayerScript.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlayerScript::OnPlayerResurrectsignature by taking theapplySicknessparameter by reference (bool&) in bothChallengeMode_HardcoreandChallengeMode_IronMan.Why
AzerothCore's
PlayerScript::OnPlayerResurrectis declared as:virtual void OnPlayerResurrect(Player*, float, bool& applySickness)(see
src/server/game/Scripting/ScriptDefines/PlayerScript.h).This module's overrides used
bool applySickness(by value), so theoverridespecifier's signature didn't match the virtual base. The function was added as a separate non-overriding member, the base's empty implementation was used at hook dispatch, and the resurrection behavior for Hardcore / Iron Man challenge modes silently never fired.Test plan
OnPlayerResurrectruns (e.g. character is marked dead viaHARDCORE_DEAD/ spirit healer flow takes effect).