Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rust crypto to support m1 macs #149

Closed
wants to merge 7 commits into from

Conversation

HRezaei
Copy link

@HRezaei HRezaei commented Nov 19, 2021

In the current version (master), Cargo build fails with an error like this, on M1 Mac's (Apple silicon chips):

= note: Undefined symbols for architecture arm64:
            “_rust_crypto_util_fixed_time_eq_asm”, referenced from:
                _$LT$crypto..aes_gcm..AesGcm$u20$as$u20$crypto..aead..AeadDecryptor$GT$::decrypt::hb979bb1f732ed3d2 in libcrypto-8dc36bae6f938f30.rlib(crypto-8dc36bae6f938f30.crypto.84e9466e-cgu.9.rcgu.o)
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

We noticed the rust-crypto crate is deprecated. This removes the dependency to rust-crypto and uses RustCrypto crates instead. Also, there were some errors related to Rocket 0.4.2, for which we upgraded to the latest release (0.5.0-rc.1) based on this guide.

Thus this branch is now successfully built with arm64 architecture on Mac. It is also tested on Ubuntu 20.04.1 LTS 64bit.

@HRezaei HRezaei changed the title Feature/deprecate rust crypto Deprecate rust crypto to support m1 macs Nov 19, 2021
@survived
Copy link

Thanks for PR, @HRezaei! We're actually getting rid of rust-crypto and nightly rocket in #144 and gg20-examples branch. But we haven't updated gg18 examples yet, so this PR appears to be very relevant! I'll merge this PR after merging two PRs above

@survived
Copy link

survived commented Jan 4, 2022

Moved to #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants