Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for "fix(mining): Advertise mined blocks" #9183

Open
wants to merge 4 commits into
base: advertise-mined-blocks
Choose a base branch
from
Open

Suggestions for "fix(mining): Advertise mined blocks" #9183

wants to merge 4 commits into from
+100 −70

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jan 31, 2025

This is a suggestion PR for #9176, it:

  • updates the documentation on a field,
  • refactors RPC error conversions,
  • skips checking if Zebra is synced to the network tip on test networks, and
  • refactors block gossip task to advertise mined blocks as soon as they're received.

@arya2 arya2 requested a review from oxarbitrage January 31, 2025 02:38
@arya2 arya2 self-assigned this Jan 31, 2025
@arya2 arya2 requested review from a team as code owners January 31, 2025 02:38
@arya2 arya2 mentioned this pull request Jan 31, 2025
Open
7 tasks
@arya2 arya2 force-pushed the suggestions-advertise-mined-blocks branch from 44a3695 to 7a26a13 Compare January 31, 2025 05:08
@arya2 arya2 force-pushed the suggestions-advertise-mined-blocks branch from 7a26a13 to ac33af4 Compare January 31, 2025 06:13
@mpguerra mpguerra linked an issue Jan 31, 2025 that may be closed by this pull request
bug: Zebra does not advertise mined blocks in some cases #8909
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage

Assignees

@arya2 arya2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Zebra does not advertise mined blocks in some cases
1 participant
@arya2