Expose ScriptError on C++ side
#195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**This changes the C++ implementation.** Provides richer errors, which also gives more precision when comparing against the Rust impl. This also removes the (now unused) `zcash_script_error_t`. The only case other than `zcash_script_ERR_OK` that was still in use was `zcash_script_ERR_VERIFY_SCRIPT`, so that case has been added to `ScriptError`. This avoids changing the Rust API, but potentially `Error` and `ScriptError` on the Rust side could be collapsed into one `enum`. It would just be a breaking change.
|
Since property/fuzz tests generally fail, this change was crucial to thorough testing of #174. Without it, there are only two failure values from the C++ side. This is also preliminary work for the deeper step-wise comparison between the interpreters, as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the C++ implementation.
Provides richer errors, which also gives more precision when comparing against the Rust impl.
This also removes the (now unused)
zcash_script_error_t. The only case other thanzcash_script_ERR_OKthat was still in use waszcash_script_ERR_VERIFY_SCRIPT, so that case has been added toScriptError.This avoids changing the Rust API, but potentially
ErrorandScriptErroron the Rust side could be collapsed into oneenum. It would just be a breaking change.