Skip to content

fix(rules): explain the blank process in a help button - #553

Merged
Zakkaus merged 1 commit into
mainfrom
fix/trace-process-help-button
Oct 19, 2026
Merged

Zakkaus merged 1 commit into
mainfrom
fix/trace-process-help-button

Conversation

@Zakkaus

@Zakkaus Zakkaus commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Follow-up to #550, which merged before this commit was pushed.

Problem

The process field's description line from #550 is wider than the field, so it widens the field's grid cell in the route trace's advanced conditions and pushes DSCP onto a new row.

How I fixed it

The explanation moves into the label's help button (help on TextField). A field label row with a help button now keeps the label's own font size and line height, so the 24 px button no longer pushes its input below the neighbouring inputs.

Verified

  • Mock preview, 1280 px: the four advanced inputs (source IP, source port, process, DSCP) share one row, top 414 px, width 164 px each; light and dark checked, popover text checked.
  • pnpm check passed; the e2e gate ran on fix(rules): trace a blank process as traffic without one #550's branch with this commit before the merge.

After light, help open, after dark:

after
help
dark

Submitted and answered for by (Human responsible, GitHub username): @Zakkaus


Check only claims that are true. A false claim closes the pull request.

  • I understand this change and will answer for every line. An AI cannot answer for me.
  • This branch is based on the current main.
  • Each commit contains one coherent change with an English type(scope): subject and a short English body.
  • I ran the applicable CI gates in CONTRIBUTING.md; the Verified section records the commands, results and any checks I could not complete.
  • I updated the strings in en.json and in every complete language's catalogue when I changed interface text.
  • I attached light and dark screenshots when I changed the interface appearance.
  • I ran pnpm gen:api and pnpm check:gen when I changed the API contract.
  • I checked the boxes above without reading them.
  • I am an AI agent, and this content was submitted without human review.

The description line under the process field was wider than the field, so it
widened its grid cell and pushed DSCP onto a new row. The explanation moves to
the label's help button. A field label row with a help button now keeps the
label's own line height, so the 24 px button no longer pushes the input below
its neighbours.
@Zakkaus
Zakkaus force-pushed the fix/trace-process-help-button branch from dd34dc0 to 94bd953 Compare October 18, 2026 04:49
@Zakkaus
Zakkaus merged commit ed40010 into main Oct 19, 2026
16 checks passed
@Zakkaus
Zakkaus deleted the fix/trace-process-help-button branch October 19, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant