Repository navigation
fix(rules): explain the blank process in a help button - #553
Merged
Merged
Conversation
The description line under the process field was wider than the field, so it widened its grid cell and pushed DSCP onto a new row. The explanation moves to the label's help button. A field label row with a help button now keeps the label's own line height, so the 24 px button no longer pushes the input below its neighbours.
Zakkaus
force-pushed
the
fix/trace-process-help-button
branch
from
October 18, 2026 04:49
dd34dc0 to
94bd953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #550, which merged before this commit was pushed.
Problem
The process field's description line from #550 is wider than the field, so it widens the field's grid cell in the route trace's advanced conditions and pushes DSCP onto a new row.
How I fixed it
The explanation moves into the label's help button (
helponTextField). A field label row with a help button now keeps the label's own font size and line height, so the 24 px button no longer pushes its input below the neighbouring inputs.Verified
pnpm checkpassed; the e2e gate ran on fix(rules): trace a blank process as traffic without one #550's branch with this commit before the merge.After light, help open, after dark:
Submitted and answered for by (Human responsible, GitHub username): @Zakkaus
Check only claims that are true. A false claim closes the pull request.
main.type(scope): subjectand a short English body.CONTRIBUTING.md; the Verified section records the commands, results and any checks I could not complete.en.jsonand in every complete language's catalogue when I changed interface text.pnpm gen:apiandpnpm check:genwhen I changed the API contract.