refactor(desktop): brand-configurable local-server readiness service name - #37
Merged
Conversation
…nd constant The readiness probe hardcoded service == "hugagent"; downstream brands whose backend reports a different /health service id would never pass readiness and local mode would hang at startup timeout (hit in practice on a downstream branch). Move the expected id to brand.rs, overridable at build time via JX_LOCAL_SERVICE_NAME. No behavior change for this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The local-server readiness probe hardcoded
service == "hugagent"when checking/health. A downstream brand whose backend reports a different service id never passes readiness — the local mode setup hangs at 99% and times out even though the backend is healthy (hit in practice on a downstream branch).brand.rsasLOCAL_SERVICE_NAME, overridable at build time viaJX_LOCAL_SERVICE_NAME.hugagent).Testing
cargo test --libindesktop/src-tauri— 33/33 pass