feat(desktop): choose run mode in the installer (dual / local-only / cloud-only) - #33
Merged
Merged
Conversation
…cloud-only) - NSIS interactive install now offers a three-way run-mode choice via chained dialogs; local-only provisions immediately, dual/cloud-only preselect the mode and the first-launch init page only asks for the server address - is_provisioned now requires an explicit provision_mode (and a saved cloud address for cloud/dual), so leftover configs from older versions get one prefilled confirmation pass instead of silently skipping the chooser - activate-local writes a full LocalOnly provision; the enterprise silent install flags (/HUGAGENT_LOCAL, /HUGAGENT_REMOTE) keep working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ensures the run-mode choice happens in the app's first-launch init page — and that nothing can silently skip it.
/HUGAGENT_LOCAL,/HUGAGENT_REMOTE) keep working for software-distribution scenarios.is_provisionednow requires an explicitprovision_modeinserver.json(plus a saved cloud address for cloud/dual). Machines carrying aserver.jsonfrom older versions no longer skip the chooser — they get one prefilled confirmation pass, then are never asked again./HUGAGENT_LOCALprovisions LocalOnly immediately;/HUGAGENT_REMOTEpreselects cloud mode and the init page only asks for the server address.activate-localwrites a full LocalOnly provision so the switch survives the stricter check.Why
On Windows the installer's old yes/no dialog pre-wrote the config, so the in-app three-mode chooser added for hybrid dual mode was unreachable — fresh installs went straight into a from-zero local setup with no dual option.
Testing
cargo test --libindesktop/src-tauri— 33/33 pass (provisioning/preselect/legacy cases covered by new tests)