fix(desktop): prevent Windows CE bootstrap encoding crash - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
Fix packaged Windows CE desktop builds exiting during the first local-server
startup after the default-plugin readiness changes from #19.
The desktop launcher redirects Python stdout and stderr to
server.log. OnWindows systems where the redirected stream selected GBK, printing the
✓status symbol raised
UnicodeEncodeErrorinside the plugin and site-templatebootstrap
tryblocks. Successful work was consequently reported as failed,and strict readiness terminated the backend before the desktop window became
usable.
This change:
log encoding problem cannot change readiness state; and
environment contract.
Related issue / 关联 Issue
Follow-up to #19.
Type of change / 变更类型
document/**,README*.md)examples/**).github/**)Checklist / 检查项
document/en/**anddocument/zh-CN/**where applicable. 双语文档已同步更新(如适用)。Validation:
brand, license, import/OpenAPI/ORM, pytest-collection, and frontend-build gates;
cargo fmt, andgit diff --checkpassed; andredirected logs, and UTF-8 environment overrides deliberately removed. The
service reached
/health, and the resulting log decoded as UTF-8 with thecompleted default-plugin status present.