Improve code style: fix imports and PEP 8 violations by Copilot · Pull Request #52 · ZHZisZZ/dllm

Copilot · 2025-12-13T13:19:15Z

Reduces stylistic inconsistencies across the codebase while preserving all functionality. Models directories remain untouched per existing black configuration.

Import Organization

Sorted imports with isort (black profile) across 60+ files
Removed unused type imports (Optional, Dict, List, Type) from data loaders and schedulers

PEP 8 Compliance

Replaced bare except: with except Exception:
Fixed None comparisons: != None → is not None
Removed trailing whitespace from example files

Original prompt

Improve code style and reduce stylistic inconsistencies with minimal changes. Exclude files under xx/models/.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: ZHZisZZ <[email protected]>

… and trailing whitespace Co-authored-by: ZHZisZZ <[email protected]>

ZHZisZZ · 2025-12-13T13:35:21Z

@copilot

revert the following changes: "Renamed ambiguous single-letter variable l → seq_len in trainer and evaluation code"

dllm/core/samplers/__init__.py

Co-authored-by: ZHZisZZ <[email protected]>

Copilot · 2025-12-13T13:38:55Z

@copilot

revert the following changes: "Renamed ambiguous single-letter variable l → seq_len in trainer and evaluation code"

Reverted the variable name changes (l → seq_len) in commit 2149c42. The original variable names are restored while preserving the import ordering improvements.

Copilot

Pull request overview

This PR improves code consistency and adherence to Python style guidelines across 60+ files in the codebase while preserving all functionality. The changes focus on import organization and PEP 8 compliance.

Key changes:

Applied isort with black profile to organize imports across the codebase (stdlib → third-party → local)
Replaced bare except: clauses with except Exception: for better exception handling practices
Fixed PEP 8 None comparisons (!= None → is not None)
Removed trailing whitespace from documentation and example files
Removed unused type hint imports that were not referenced in the code

Reviewed changes

Copilot reviewed 60 out of 66 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
scripts/tests/test_attention.py	Sorted imports: pytest moved after third-party imports
examples/llada/sft.py, pt.py, chat.py	Removed trailing whitespace; sorted imports (accelerate before transformers)
examples/editflow/*.py	Sorted imports alphabetically; removed trailing whitespace from comments
examples/dream/*.py	Sorted imports; removed trailing whitespace from documentation
examples/bert/*.py	Sorted imports; removed trailing whitespace
examples/a2d//.py	Sorted imports; removed trailing whitespace
dllm/utils/visualizers.py	Sorted imports from rich library alphabetically; sorted stdlib imports
dllm/utils/utils.py	Sorted imports: logging before os; alphabetized third-party imports
dllm/utils/models.py	Fixed bare except → except Exception; fixed None comparison to use `is not None`; sorted imports
dllm/utils/data.py	Sorted imports; alphabetized TYPE_CHECKING imports
dllm/utils/configs.py	Alphabetized local imports
dllm/utils/collators.py	Moved typing import to proper position with blank line separator
dllm/utils/chat.py	Moved typing imports after stdlib; removed extra blank lines
dllm/utils/init.py	Alphabetized import order
dllm/tools/*.py	Sorted imports alphabetically
dllm/pipelines/*/eval.py	Sorted imports: moved tqdm after lm_eval imports
dllm/pipelines//init*.py	Alphabetized imports for consistency
dllm/pipelines/editflow/utils.py	Alphabetized typing imports
dllm/pipelines/editflow/trainer.py	Alphabetized typing imports; removed extra blank lines
dllm/pipelines/dream/sampler.py	Sorted imports: torch.distributions after torch.nn.functional
dllm/data/*.py	Removed unused type imports (Optional, List, Dict); sorted remaining imports
dllm/core/trainers/*.py	Moved typing imports to proper position after from future
dllm/core/schedulers/*.py	Removed unused type imports (Dict, Type); added blank line after future
dllm/core/samplers/*.py	Sorted base imports alphabetically; removed multi-line import formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-13T13:48:05Z

dllm/utils/__init__.py

 from .data import *
-from .sampling import *
 from .models import *
+from .sampling import *


Import pollutes the enclosing namespace, as the imported module dllm.utils.sampling does not define 'all'.

Copilot · 2025-12-13T13:48:05Z

dllm/utils/data.py


 if TYPE_CHECKING:
-    from dllm.utils.configs import ModelArguments, DataArguments, TrainingArguments
+    from dllm.utils.configs import DataArguments, ModelArguments, TrainingArguments


Import of 'ModelArguments' is not used.
Import of 'TrainingArguments' is not used.

Copilot · 2025-12-13T13:48:05Z

dllm/utils/models.py


-from dllm.utils.utils import disable_caching_allocator_warmup, print_main, load_peft
 from dllm.utils.configs import ModelArguments, TrainingArguments
+from dllm.utils.utils import disable_caching_allocator_warmup, load_peft, print_main


Import of 'disable_caching_allocator_warmup' is not used.

Copilot · 2025-12-13T13:48:06Z

dllm/tools/preprocess_pt_dataset.py


 import os
-from dataclasses import dataclass, asdict
+from dataclasses import asdict, dataclass


Import of 'asdict' is not used.

Copilot · 2025-12-13T13:48:06Z

dllm/tools/preprocess_pt_dataset.py

-from dataclasses import dataclass, asdict
+from dataclasses import asdict, dataclass
 from functools import partial
+from pprint import pprint


Import of 'pprint' is not used.

Copilot · 2025-12-13T13:48:06Z

dllm/utils/utils.py

-import logging
 from contextlib import contextmanager
-from dataclasses import dataclass, asdict
+from dataclasses import asdict, dataclass


Import of 'dataclass' is not used.

Copilot · 2025-12-13T13:48:07Z

dllm/pipelines/editflow/utils.py

-from typing import Any, Dict, List, Optional, Tuple, Text
 from collections.abc import Callable
+from dataclasses import dataclass
+from typing import Any, Dict, List, Optional, Text, Tuple


Import of 'Dict' is not used.
Import of 'List' is not used.
Import of 'Tuple' is not used.
Import of 'Optional' is not used.
Import of 'Text' is not used.

Suggested change

from typing import Any, Dict, List, Optional, Text, Tuple

from typing import Any

Copilot · 2025-12-13T13:48:07Z

examples/editflow/viz.py

 import re
 import unicodedata
-from typing import Optional, List, Tuple, Annotated
+from typing import Annotated, List, Optional, Tuple


Import of 'Tuple' is not used.
Import of 'Optional' is not used.
Import of 'Annotated' is not used.

Copilot · 2025-12-13T13:48:07Z

examples/editflow/viz.py

-from typing import Optional, List, Tuple, Annotated
+from typing import Annotated, List, Optional, Tuple
+
+from PIL import Image, ImageDraw, ImageFont


Import of 'Image' is not used.
Import of 'ImageDraw' is not used.
Import of 'ImageFont' is not used.

Copilot · 2025-12-13T13:48:07Z

dllm/utils/visualizers.py

 from abc import ABC, abstractmethod
-from typing import Sequence, Optional
+from dataclasses import dataclass
+from typing import Optional, Sequence


Import of 'Sequence' is not used.

Initial plan

ec6e11a

Copilot AI assigned Copilot and ZHZisZZ Dec 13, 2025

Copilot started work on behalf of ZHZisZZ December 13, 2025 13:20 View session

Copilot AI and others added 2 commits December 13, 2025 13:25

Fix import ordering and ambiguous variable names

e251801

Co-authored-by: ZHZisZZ <[email protected]>

Fix remaining ambiguous variable names, bare except, None comparison,…

dcc799c

… and trailing whitespace Co-authored-by: ZHZisZZ <[email protected]>

Copilot AI changed the title ~~[WIP] Improve code style and reduce inconsistencies~~ Improve code style: fix variable names, imports, and PEP 8 violations Dec 13, 2025

Copilot AI requested a review from ZHZisZZ December 13, 2025 13:33

Copilot finished work on behalf of ZHZisZZ December 13, 2025 13:33

Copilot started work on behalf of ZHZisZZ December 13, 2025 13:36 View session

ZHZisZZ reviewed Dec 13, 2025

View reviewed changes

dllm/core/samplers/__init__.py Show resolved Hide resolved

Revert variable name changes (l → seq_len), keep import ordering fixes

2149c42

Co-authored-by: ZHZisZZ <[email protected]>

Copilot AI changed the title ~~Improve code style: fix variable names, imports, and PEP 8 violations~~ Improve code style: fix imports and PEP 8 violations Dec 13, 2025

Copilot AI requested a review from ZHZisZZ December 13, 2025 13:40

Copilot finished work on behalf of ZHZisZZ December 13, 2025 13:40

Copilot started work on behalf of ZHZisZZ December 13, 2025 13:40 View session

Copilot finished work on behalf of ZHZisZZ December 13, 2025 13:42

ZHZisZZ marked this pull request as ready for review December 13, 2025 13:43

ZHZisZZ requested a review from Copilot December 13, 2025 13:44

Copilot started reviewing on behalf of ZHZisZZ December 13, 2025 13:45 View session

Copilot AI reviewed Dec 13, 2025

View reviewed changes

ZHZisZZ merged commit d73203d into dev Dec 13, 2025
7 checks passed

ZHZisZZ deleted the copilot/improve-code-style branch January 1, 2026 14:48

	from typing import Any, Dict, List, Optional, Text, Tuple
	from typing import Any

Conversation

Copilot AI commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Import Organization

PEP 8 Compliance

Uh oh!

ZHZisZZ commented Dec 13, 2025

Uh oh!

Uh oh!

Copilot AI commented Dec 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 13, 2025 •

edited

Loading