fix(omp): upgrade to OMP 17.4.2 for ask option descriptions - #30
Merged
Conversation
17.4.2 is the first oh-my-pi release carrying the ask optionDetails fix (can1357/oh-my-pi#9175, merged in #9176), which this repo's OMP adapter now consumes.
joeshull
force-pushed
the
omp-upgrade-17.4.2
branch
2 times, most recently
from
August 22, 2026 14:41
2fd39f8 to
dbe9bdd
Compare
toMatchObject ignores extra/missing keys, so the described-select and malformed-metadata tests passed even with option-index misalignment or an unfiltered whitespace-only description. Switched to toStrictEqual on the options array so both are actually caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
askoptionDetailsmetadata. Renders described select options while keeping legacy label-only and malformed-metadata fallback behavior.MIN_SUPPORTED_OMP_VERSIONfrom16.3.9to17.4.2, the first oh-my-pi release containing the fix.Downstream feature: true
Downstream rationale: Ports content from an open upstream PR (getpaseo#3628) that is not yet merged, so upstream patch-equivalence and reconciled-merge provenance cannot be established. internal/main has diverged from fork main by 93 commits including OMP-provider code not present upstream, so a direct/reconciled import cannot land conflict-free; this is fork-only until the upstream PR merges.
Related
Notes
daemon-e2e/omp.real.e2e.test.ts) requires an actual installedompbinary and needs to be exercised in a session with OMP available, not this one.Verification
npx vitest run src/server/agent/providers/omp/agent.diagnostic.test.ts src/server/agent/providers/omp/agent.test.ts src/server/agent/providers/omp/rpc-ui-permission-mapper.test.ts --bail=1— 83 passednpm run typechecknpm run lint/npm run formaton changed filesTest plan
asktool call with described options and confirm descriptions render in Paseo's question card.askcalls (no descriptions) still behave as before.