This repository was archived by the owner on Aug 17, 2026. It is now read-only.
fix(client): guard ChatView virtualizer onChange after unmount - #21
Merged
Conversation
Prevents vitest unhandled "window is not defined" when tanstack virtual notifies after jsdom teardown (CI suite error with all tests green).
joeshull
requested review from
NathanielDake,
cmditch,
tomNummy and
tyler-keller
July 17, 2026 01:11
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks develop CI post-#20: suite failed with unhandled virtualizer notify after ChatView tests despite 9833 passing. Guard onChange when window gone / element disconnected.