Skip to content

Add CredentialRepositoryV2 to supersede CredentialRepository #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

iaik-jheher
Copy link
Contributor

This is part of the UserIdentity work I proposed in #289 (comment); I am breaking it down into smaller parts for ease of review.

This part supersedes the current CredentialRepository interface with a new CredentialRepositoryV2 interface. CredentialRepositoryV2 works based on UserIdentity objects, not usernames.

The CredentialRepository interface extends CredentialRepositoryV2, and has appropriate default implementations to allow existing repositories to continue to function unmodified.

(This pull request does not actually use the V2 interface or its functions anywhere, yet.)

@emlun
Copy link
Member

emlun commented Nov 9, 2023

This is now superseded by experimental release 2.6.0-alpha4, which includes a new CredentialRepositoryV2 aiming to solve the same problems, but with a different architecture. I hope this supports your use case; if not, please let us know!

@emlun emlun closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants