Add CredentialRepositoryV2
to supersede CredentialRepository
#292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the
UserIdentity
work I proposed in #289 (comment); I am breaking it down into smaller parts for ease of review.This part supersedes the current
CredentialRepository
interface with a newCredentialRepositoryV2
interface.CredentialRepositoryV2
works based onUserIdentity
objects, not usernames.The
CredentialRepository
interface extendsCredentialRepositoryV2
, and has appropriatedefault
implementations to allow existing repositories to continue to function unmodified.(This pull request does not actually use the
V2
interface or its functions anywhere, yet.)