Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh PHPUnit setup #31

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

Anve94
Copy link
Member

@Anve94 Anve94 commented Mar 10, 2025

  • Move PHPUnit dependency from require to require-dev
  • Rewrite unit tests for PHPUnit 12
  • Install phpunit upstream with dependency installer while honoring/keeping upstream versions
  • Add unit tests for package installer changes to install phpunit upstream
  • Refresh github actions and run workflows for php 8.1, 8.2 and 8.3
  • Drop php support for versions < 8.1
  • Drop youwe/coding-standard-phpstorm package and add as suggest

@Anve94
Copy link
Member Author

Anve94 commented Mar 10, 2025

FYI I also updated/fixed the github actions for this. See checks below for reference.

This PR will also resolve #19 and #21 once release/version3 is merged to main.

@Anve94 Anve94 force-pushed the feature/v3-dependency-updates branch 2 times, most recently from b93bead to d7cd101 Compare March 11, 2025 12:33
@youwe-petervanderwal
Copy link
Contributor

youwe-petervanderwal commented Mar 11, 2025

Approving but would be great if the installPackage is tested with the correct with() (2x)
Don't want to block it though

Edit: why doesn't Github allow me to approve with these two comments.... Anyway, the merge is not blocked, you can see this comment as an approval then

* Move PHPUnit dependency from require to require-dev
* Rewrite unit tests for PHPUnit 12
* Install phpunit upstream with dependency installer while
honoring/keeping upstream versions
* Add unit tests for package installer changes to install
phpunit upstream
* Refresh github actions and run workflows for php 8.1, 8.2, 8.3 and 8.4
* Drop php support for versions < 8.1
* Drop composer 1 support
* Drop youwe/coding-standard-phpstorm package and add as suggest
@Anve94 Anve94 force-pushed the feature/v3-dependency-updates branch from d7cd101 to 07b0731 Compare March 12, 2025 08:15
@Anve94 Anve94 merged commit d1e64b5 into release/version3 Mar 12, 2025
4 checks passed
@Anve94 Anve94 deleted the feature/v3-dependency-updates branch March 12, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants