-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve function words list for Farsi #21958
base: trunk
Are you sure you want to change the base?
Conversation
Added some adjectives and adverbs Added some auxiliary verbs Added some more populat forms of intensifiers Removed nonwritten ی in prepositions
Pull Request Test Coverage Report for Build f32a4d85ef7fc9da584d909710677f95a05aa5aeWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Thank you. |
…nWordsSpec.js remove accidentally created file
Thank you too for contributing! |
"از قبیل", "از لحاظ", "از حیث", "از جمله ی", "در برابر", "در مقابل", "درباره ی", "درمورد", "درمیان", "درخصوص", | ||
"براثر", "براساس", "برطبق", "برحسب", "با وجود" ]; | ||
|
||
const postposition = [ "را" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "postpositions" category was removed because the word is already listed in pronouns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean all the words in the category postpositions
are included in pronouns
?
CR: comments and discussion in this slack thread |
Context
When reviewing and testing, it was noticed that multiple-word function words don't get recognised by the content analysis. This PR fixes that.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
In Wordpress
مقدار زیادی
,باید
,سرکار آقای
,فقط
,پیش ظهر
.Your keyphrase X contains function words only. Learn more about what makes a good keyphrase.
ارزش
as the keyphraseاندک اندک ارزش
as the keyphrase titleThe exact match of the focus keyphrase appears at the beginning of the SEO title. Good job!
In Shopify
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #21903