drop sorting

drop sort drop sorting from tests
Yoast · Jan 15, 2025 · 0c89765 · 0c89765
1 parent 423ee4a
commit 0c89765
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/packages/js/src/dashboard/components/dashboard-table.js b/packages/js/src/dashboard/components/dashboard-table.js
@@ -39,7 +39,7 @@ export const DashboardTable = ( { title, columns, data } ) => {
 				{ title }
 			</Title>
 			<div className="yst-overflow-auto">
-				<table className="yst-site-kit-widget-table">
+				<Table variant="minimal">
 					<Table.Head className="yst-bg-white yst-mt-2 yst-border-b-slate-300 yst-border-b yst-border-t-0">
 						<Table.Row>
 							<Table.Header>{ "" }</Table.Header>
@@ -67,7 +67,7 @@ export const DashboardTable = ( { title, columns, data } ) => {
 							</Table.Row>
 						) ) }
 					</Table.Body>
-				</table>
+				</Table>
 			</div>
 		</Paper>
 	);

diff --git a/packages/js/tests/dashboard/components/dashboard-table.test.js b/packages/js/tests/dashboard/components/dashboard-table.test.js
@@ -1,12 +1,12 @@
-import { render, screen, fireEvent } from "../../test-utils.js";
+import { render, screen } from "../../test-utils.js";
 import "@testing-library/jest-dom";
 import { DashboardTable } from "../../../src/dashboard/components/dashboard-table.js";
 import { SCORE_META } from "../../../src/dashboard/scores/score-meta.js";
 
 describe( "DashboardTable", () => {
 	const columns = [
 		{ name: "landing-page", label: "Landing page" },
-		{ name: "clicks", label: "Clicks", sortable: true },
+		{ name: "clicks", label: "Clicks" },
 		{ name: "impressions", label: "Impressions" },
 		{ name: "ctr", label: "CTR" },
 		{ name: "average-position", label: "Average position" },
@@ -41,13 +41,4 @@ describe( "DashboardTable", () => {
 			expect( rowElement ).toHaveTextContent( SCORE_META[ row[ 5 ] ].label );
 		} );
 	} );
-
-	it( "sorts the table correctly when a sortable column header is clicked", () => {
-		render( <DashboardTable title="Test Table" columns={ columns } data={ data } /> );
-		const clicksHeader = screen.getByText( "Clicks" );
-		fireEvent.click( clicksHeader );
-		const sortedData = data.sort( ( a, b ) => a[ 1 ] - b[ 1 ] );
-		const firstRow = screen.getAllByRole( "row" )[ 1 ];
-		expect( firstRow ).toHaveTextContent( sortedData[ 0 ][ 0 ] );
-	} );
 } );