adding tests and then deploy - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the foundational Foundry test suite for the
YieldSaveVaultsmart contract. It ensures the core functionality of the Phase 1 MVP operates securely and accurately integrates with Aave V3.Key Changes
YieldSaveVault.t.solto use a Base Sepolia fork environment for accurate, deterministic Aave V3 integration testing.userShares,userDeposits), and zero-amount deposit reverts.getVaultBalance,getUserBalance,previewWithdraw, andpreviewWithdrawFor(including edge cases for zero shares and non-existent users).Type of Change