Fix bugs and expand test coverage - #32
Merged
Merged
Conversation
- Fix inverse auto-detection for left, right, and square inverses - Fix sep_unk symbol splitting and symbolic scalar_factor verification - Handle zero-subspace checks in is_subspace_of - Use Hermitian projection coefficients in Gram-Schmidt - Optimize full QR basis extension via orthogonal complement - Improve solve_least_squares empty solver-result handling - Avoid unnecessary columnspace calls in diagonalization and SVD paths
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31 .
Summary
This PR fixes several symbolic matrix regressions found while exercising the tutorial and test suite, and adds more test coverage for matrix factories, manipulators, decompositions, and linear transformations.
Highlights
from_list,sep_unk,scalar_factor, inverse detection, basis/transition operations, Gram-Schmidt with complex vectors, full QR decomposition, least-squares fallback handling, diagonalization, SVD verification, and Vandermonde substitution.utils._is_IPython()whenget_ipython()returnsNoneor the IPython import is unavailable._shape, Vandermonde helpers, symbolic row reduction, least-squares and QR branches, eigen/stochastic helpers, SVD fallbacks,standard_matrix, and utility display/IPython paths.package-lock.json.