Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added register form #76

Merged
merged 4 commits into from
Jun 24, 2024
Merged

added register form #76

merged 4 commits into from
Jun 24, 2024

Conversation

mahek0620
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@Yeasir0032
Copy link
Owner

Your dark and light mode are not according to best practices used in the project.
Please check different Components, how they have used dark mode and light mode.

@mahek0620
Copy link
Contributor Author

@Yeasir0032 can you check updated register.tsx

Copy link
Owner

@Yeasir0032 Yeasir0032 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something more you have to change

  • Remove the Theme toggle button as there is a global toggle.
  • Remove unnecessary use of next themes.

@Yeasir0032
Copy link
Owner

You should follow Pull Request Format - Adding the issue reference, Ticking some textboxes.

@mahek0620
Copy link
Contributor Author

Related Issue
Fixes #65

Description
Removed the Theme toggle button as there is a global toggle.
Removed unnecessary use of next themes.

Type of PR
Bug fix
[ X] Feature enhancement
Documentation update
Other (specify): _______________
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:
I have performed a self-review of my code
[ X] I have read and followed the Contribution Guidelines.
[X ] I have tested the changes thoroughly before submitting this pull request.
[X ] I have commented my code, particularly in hard-to-understand areas.

@mahek0620 mahek0620 requested a review from Yeasir0032 May 29, 2024 13:22
@mahek0620
Copy link
Contributor Author

@Yeasir0032 can you please check the updated register form

@mahek0620
Copy link
Contributor Author

@Yeasir0032 kindly add labels to it

@mahek0620
Copy link
Contributor Author

@Yeasir0032 please review it

@mahek0620
Copy link
Contributor Author

@PayalKumari10 kindly review it

@mahek0620
Copy link
Contributor Author

@Yeasir0032 can you review it the change which you requested has been modified

@Yeasir0032 Yeasir0032 merged commit 76e345b into Yeasir0032:main Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants