Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Docker file for the Discord-Clone #34 #56

Merged
merged 1 commit into from
May 22, 2024

Conversation

KanishkChhajed
Copy link
Contributor

@KanishkChhajed KanishkChhajed commented May 19, 2024

Related Issue

Creating a Dockerfile as described in issue#34

Description

Create a Dockerfile :

  • Taking Base image as Ubuntu
  • Create Docker Container for Node version 20
  • Run this file → docker build -t <image_name> .
    NOTE: replace <image_name> with suitable image name.
    Example : docker build -t discord-clone .

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@Yeasir0032
Copy link
Owner

Can you explain a bit, what this does

@KanishkChhajed
Copy link
Contributor Author

KanishkChhajed commented May 20, 2024

It's a basic Dockerfile in which you found an isolated container containing Ubuntu as base operating system and in that system we provide Node.js of version 20.

@KanishkChhajed
Copy link
Contributor Author

@Yeasir0032 I would like to know what I can improve in this issue, so I can work on it.

@Yeasir0032 Yeasir0032 requested a review from PayalKumari10 May 20, 2024 23:26
@Yeasir0032 Yeasir0032 merged commit 2c16045 into Yeasir0032:main May 22, 2024
1 check passed
Yeasir0032 added a commit that referenced this pull request May 23, 2024
Yeasir0032 added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants