-
Notifications
You must be signed in to change notification settings - Fork 348
fix(session): admit ownerless continuation before selection #4540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b441398
162d2c8
bd98e24
cec2d55
33dc4d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1317,6 +1317,7 @@ function createControlSurface( | |
| onPreflightAcceptCommit: () => Promise<void>; | ||
| /** Fired when a queued submission (steering or follow-up) is promoted to its own run (SDK ownership correlation). */ | ||
| onQueuedPromoted: () => void; | ||
| queuedAtDispatch: boolean; | ||
| }) => Promise<unknown>, | ||
| acceptedFields?: () => Record<string, unknown>, | ||
| allowCompletionFallback = false, | ||
|
|
@@ -1392,6 +1393,7 @@ function createControlSurface( | |
| // created at promotion so the submitting connection can | ||
| // terminal-abort that turn (review threads P1/P2). | ||
| onQueuedPromoted: () => onPromotedTurn?.(kind, correlation, requesterConnectionId), | ||
| queuedAtDispatch, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When Useful? React with πΒ / π. |
||
| }), | ||
| ); | ||
| void submission.then( | ||
|
|
@@ -2316,10 +2318,10 @@ function createControlSurface( | |
| }; | ||
| return { | ||
| prompt: async (text, images, clientRef) => | ||
| submit("prompt", clientRef, options => | ||
| submit("prompt", clientRef, ({ queuedAtDispatch, ...options }) => | ||
| api.sendUserMessage( | ||
| typeof images === "undefined" ? text : ([{ type: "text", text }, ...(images as never[])] as never), | ||
| options, | ||
| queuedAtDispatch ? { ...options, queuedAtDispatch: true } : options, | ||
| ), | ||
| ), | ||
| steer: async (text, clientRef) => { | ||
|
|
@@ -2355,7 +2357,7 @@ function createControlSurface( | |
| }, | ||
| abortTerminal: terminalAbort, | ||
| abortAndPrompt: async text => { | ||
| ctx.abort(); | ||
| await ctx.abort(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When Useful? React with πΒ / π. |
||
| return await submit("prompt", undefined, options => api.sendUserMessage(text, options)); | ||
| }, | ||
| answerAsk: unavailable("ask.answer"), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes observable coding-agent SDK admission, abort, and continuation behavior, but the commit contains no entry under
packages/coding-agent/CHANGELOG.md'sUnreleasedsection. The repository contract requires package changes to be recorded there, so the release would otherwise omit this user-visible fix from its changelog.AGENTS.md reference: AGENTS.md:L188-L188
Useful? React with πΒ / π.