-
Notifications
You must be signed in to change notification settings - Fork 342
fix(coordinator-mcp): answer ping keepalive with empty result #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5698,6 +5698,9 @@ export function createCoordinatorMcpServer(options: CoordinatorMcpServerOptions | |
| }, | ||
| }; | ||
| } | ||
| if (request.method === "ping") { | ||
| return { jsonrpc: "2.0", id, result: {} }; | ||
|
Comment on lines
+5701
to
+5702
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When an integration calls the exported Useful? React with 👍 / 👎. |
||
| } | ||
| if (request.method === "tools/list") { | ||
| return { jsonrpc: "2.0", id, result: { tools: COORDINATOR_MCP_TOOL_NAMES.map(toolSchema) } }; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes user-visible MCP behavior for clients that use
pingas a liveness probe, but the commit leavespackages/coding-agent/CHANGELOG.mdunchanged, so the fix will be absent from the package's release notes. Add an entry under its## [Unreleased]section.AGENTS.md reference: AGENTS.md:L186-L186
Useful? React with 👍 / 👎.