Skip to content

fix(telegram): require documented archive settlement errors - #4041

Closed
twoimo wants to merge 6 commits into
Yeachan-Heo:devfrom
twoimo:feat/telegram-topic-authority-v13
Closed

fix(telegram): require documented archive settlement errors#4041
twoimo wants to merge 6 commits into
Yeachan-Heo:devfrom
twoimo:feat/telegram-topic-authority-v13

Conversation

@twoimo

@twoimo twoimo commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

This successor ports the Telegram shared durable-authority slice onto current dev and addresses the final exact-head review blocker from #3700.

  • Require Telegram error_code: 400 for allowlisted already-closed/not-found archive responses.
  • Keep identical text under 401, 403, 429, and 500 retryable, with regression coverage.
  • Preserve daemon owner postmortem authority and refresh the generation manifest for the current dev tip.
  • Keep the durable archive recovery, CAS fencing, Windows exact replacement, and focused e2e coverage from the reviewed predecessor.

Verification

  • Focused Telegram authority/daemon/CAS/race/postmortem/e2e suites: 649 pass, 0 fail.
  • bun --cwd=packages/coding-agent run check:types: pass.
  • Generation guard current-tree validation: pass.
  • Biome focused check: pass.

This is intentionally unmerged. Please review the exact current head and rerun the upstream gates.

@twoimo

twoimo commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

The sole CI failure was the current-dev public-sync policy: docs-index.generated.ts must remain untracked and be regenerated by the prepare hook. I removed the tracked generated file in commit 793347e35; no product scope changed. Please rerun the exact-head gates.

@twoimo

twoimo commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

The prior Local public surfaces failure was attached to superseded head 238ea2e98. Current head is 793347e35, which removes the tracked generated docs index; its fresh run has no failures and only state/public validation gates pending.

@twoimo

twoimo commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

The generation guard found one current-dev lifecycle change after the archive predicate fix. I advanced DAEMON_GENERATION from 51 to 52 and regenerated the manifest in 452e1291b. Revalidation passes: focused daemon/topic/postmortem tests 616/0, generation guard, coding-agent typecheck, and Biome clean. Please rerun the exact-head gates.

@Yeachan-Heo

Copy link
Copy Markdown
Owner

Thanks for the archive-settlement correction. I’m closing this revision because its generation baseline regresses the current daemon contract: the branch sets DAEMON_GENERATION to 52 while current dev is already at 56, so the required protected lifecycle changes cannot satisfy the monotonic generation guard. The current-dev successor is the appropriate review surface; it retains a higher generation rather than rolling the contract backward.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo Yeachan-Heo closed this Aug 8, 2026
@twoimo

twoimo commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

The guard failure was caused by current dev already advancing Telegram generation to 56 after this branch was based. I rebased the contract onto current dev, advanced the successor to generation 57, regenerated the manifest, and pushed 291403374. Revalidation: 616 pass / 0 fail focused tests, generation guard, typecheck, and Biome clean. Please rerun exact-head gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants