Skip to content

fix(coding-agent): assert goal_updated payload instead of emit arity #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yeachan-Heo merged 1 commit into from
Jul 31, 2026
Merged

fix(coding-agent): assert goal_updated payload instead of emit arity #3637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/coding-agent/test/goals/goal-mode-integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,11 @@ describe("InteractiveMode goal mode integration", () => {
const extensionError = new TypeError(
'The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined',
);
const emit = vi.fn(async (event: { type: string }) => {
if (event.type === "goal_updated") throw extensionError;
});
const emit = vi.fn(
async (event: { type: string; goal?: { status?: string } | null; state?: { mode?: string } }) => {
if (event.type === "goal_updated") throw extensionError;
},
);
harness = await createGoalHarness({
extensionRunner: { emit, getRegisteredCommands: () => [] } as unknown as ExtensionRunner,
});
Expand All @@ -398,7 +400,11 @@ describe("InteractiveMode goal mode integration", () => {
expect(result.details?.goal?.status).toBe("complete");
expect(harness.session.getGoalModeState()?.goal.status).toBe("complete");
expect(harness.session.getGoalModeState()?.mode).toBe("exiting");
expect(emit).toHaveBeenCalledWith(expect.objectContaining({ type: "goal_updated" }));
const goalUpdates = emit.mock.calls.map(([event]) => event).filter(event => event.type === "goal_updated");
expect(goalUpdates.length).toBeGreaterThan(0);
const terminalUpdate = goalUpdates[goalUpdates.length - 1];
expect(terminalUpdate?.goal?.status).toBe("complete");
expect(terminalUpdate?.state?.mode).toBe("exiting");
});

it("does not loop AgentBusyError when a busy/orphaned session triggers goal continuation", async () => {
Expand Down
Loading