fix: show pre-loaded model status in Gradio UI when initialized via CLI arguments - #5
Open
dailingx wants to merge 1 commit into
Open
fix: show pre-loaded model status in Gradio UI when initialized via CLI arguments#5dailingx wants to merge 1 commit into
dailingx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Problem
When the model is loaded at startup via
--model-pathand--tokenizer-pathCLI arguments,the "Initialization status" textbox in the Gradio UI still shows the placeholder text
"Click the initialize model button to start...", giving the false impression that the model
has not been initialized yet.
Solution
Pass the initialization result message from
initialize_model()intocreate_interface()asinit_status_msg, and use it as the initialvalueof the status textbox. When the model ispre-loaded via CLI, the UI immediately reflects the actual state ("Model loaded successfully!")
on page load.
Changes
create_interface()now accepts an optionalinit_status_msgparameter (defaults to"")main()captures the return value ofinitialize_model()and forwards it tocreate_interface()Behavior After Fix