Skip to content

fix(tui): align slash autocomplete descriptions for CJK aliases #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iwctwbh wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix(tui): align slash autocomplete descriptions for CJK aliases #1981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/opencode/src/cli/cmd/tui/component/prompt/autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { BoxRenderable, TextareaRenderable, KeyEvent, ScrollBoxRenderable } from "@opentui/core"
import { pathToFileURL } from "bun"
import fuzzysort from "fuzzysort"
import { firstBy } from "remeda"
import { createMemo, createResource, createEffect, onMount, onCleanup, Index, Show, createSignal } from "solid-js"
import { createStore } from "solid-js/store"
import { useSDK } from "@tui/context/sdk"
Expand Down Expand Up @@ -424,11 +423,14 @@ export function Autocomplete(props: {

results.sort((a, b) => a.display.localeCompare(b.display))

const max = firstBy(results, [(x) => x.display.length, "desc"])?.display.length
// Pad in terminal columns, not code units: CJK slash aliases (e.g. zh "前端设计")
// render two cells wide, so String.length + padEnd() would push the right-hand
// description column out of alignment.
const max = Math.max(0, ...results.map((x) => Bun.stringWidth(x.display)))
if (!max) return results
return results.map((item) => ({
...item,
display: item.display.padEnd(max + 2),
display: item.display + " ".repeat(Math.max(0, max + 2 - Bun.stringWidth(item.display))),
}))
})

Expand Down
Loading