Skip to content

Add symbol names in main & menu overlays#17

Open
maciej-trebacz wants to merge 3 commits intoXeeynamo:mainfrom
maciej-trebacz:feat/menu-symbol-names
Open

Add symbol names in main & menu overlays#17
maciej-trebacz wants to merge 3 commits intoXeeynamo:mainfrom
maciej-trebacz:feat/menu-symbol-names

Conversation

@maciej-trebacz
Copy link
Contributor

@maciej-trebacz maciej-trebacz commented Dec 28, 2025

No description provided.

@decomp-dev
Copy link

decomp-dev bot commented Dec 28, 2025 •
edited
Loading

Report for us (91868eb - b432b6f)

[!] Report not found. Did the build succeed?

Xeeynamo
Xeeynamo approved these changes Dec 29, 2025
View reviewed changes
Copy link
Owner

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am wondering if at some point we should differentiate the naming convention between global variables and functions (for example, is ButtonsDown a function or a variable?? it's a bit confusing at first). While we decide what's best, I am happy to have these name changes in the repo!

I can have this merged once the other two comments are addressed. Thanks for contributing 🙌

tools/docker-build.sh
@@ -0,0 +1,19 @@
#!/bin/bash
Copy link
Owner

@Xeeynamo Xeeynamo Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this as it is already part of #16

Copy link
Contributor Author

@maciej-trebacz maciej-trebacz Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is stacked on top of #16, once that one is merged this change will disappear

CLAUDE.md Outdated
Copy link
Owner

@Xeeynamo Xeeynamo Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still refraining to have this added in the REPO. I have my own AGENT.md too I should commit to a separate branch. But let's not have it to the main branch as some potential future contributors might find it controversial 😅. The same comment applies for #16

@Xeeynamo Xeeynamo mentioned this pull request Dec 29, 2025
Merged
@Xeeynamo
Copy link
Owner

Xeeynamo commented Jan 6, 2026

Conflicts must be resolved before I can merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xeeynamo Xeeynamo Xeeynamo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maciej-trebacz @Xeeynamo

Comments