Added NeoWaitTime #296
Added NeoWaitTime #296
Conversation
5.0.1 release
wurzelkuchen
left a comment
wurzelkuchen
left a comment
There was a problem hiding this comment.
Some smaller notes + Need to rework some requirements, will update ticket.
|
|
||
| import com.codeborne.selenide.Selenide; | ||
|
|
||
| public class NeoWaitTime |
There was a problem hiding this comment.
After some reconsideration on how to make this functionality as easy to access as possible (and easy to find without reading the whole documentation), Let's change the approach a bit:
- we do not provide a seperate class for this
- we add the wait methods (like
waitStandardWaitTime()) directly to the Neodymium Class so that a user can callNeodymium.waitStandardWaitTime() - we add getter Methods to our config class to get each value as a java.time.Duration object (which is needed for all of Selenides should... methods).
I'll update the ticket for clarification as well.
| { | ||
| INSTANCE = new NeoWaitTime(); | ||
| } | ||
| Selenide.sleep(Integer.valueOf(INSTANCE.customWaitTimeMap.get(key))); |
There was a problem hiding this comment.
We should add a proper handling if the key given is not present and produce a proper error message, otherwise a not very communicative NullPointerException will be thrown
| import com.codeborne.selenide.Selenide; | ||
|
|
||
| public class NeoWaitTime | ||
| { |
There was a problem hiding this comment.
The simple Selenide.Wait() case is much less common than the $("something").shouldBe(visible, Duration.ofMillis(1000)); case. So for easy access to our property we should offer a java.time.Duration version of each of our waiting times.
No description provided.