Change type to var

src/test/java/posters/cucumber/support/BrowseRandomVisualAssertSupport.java

@@ -21,7 +21,7 @@ public class BrowseRandomVisualAssertSupport
     @Given("^homepage is open")
     public void openHomePageAndValidate()
     {
-        HomePage homepage = OpenPageFlows.homepage();
+        var homepage = OpenPageFlows.homepage();
         homepage.validateAndVisualAssert();
     }
 
@@ -37,7 +37,7 @@ public void openRandomSubCategoryAndValidate(String seed)
             random = new Random(Long.valueOf(seed));
         }
         String categoryName = new HomePage().topNav.getRandomSubcategoryName(random);
-        CategoryPage categoryPage = new HomePage().topNav.clickSubcategoryByName(categoryName);
+        var categoryPage = new HomePage().topNav.clickSubcategoryByName(categoryName);
         categoryPage.isExpectedPage();
         categoryPage.validateAndVisualAssert(categoryName);
     }

src/test/java/posters/cucumber/support/CartSupport.java

@@ -20,15 +20,15 @@ public CartSupport(GlobalStorage storage)
     @When("^I open the cart$")
     public void openCart()
     {
-        CartPage cartPage = new ProductdetailPage().miniCart.openCartPage();
+        var cartPage = new ProductdetailPage().miniCart.openCartPage();
         cartPage.isExpectedPage();
     }
 
     @Then("^I see all the added products in the cart and their properties are correct$")
     public void validateProductsInTheCart()
     {
         double subtotal = 0.0;
-        CartPage cartPage = new CartPage();
+        var cartPage = new CartPage();
 
         for (Product product : storage.products)
         {
@@ -41,7 +41,7 @@ public void validateProductsInTheCart()
     @Then("^I can change amount of the \"([^\"]*)\" with \"([^\"]*)\" and \"([^\"]*)\" to (\\d+)$")
     public void updateCountOfProduct(String productName, String size, String style, int amount)
     {
-        CartPage cartPage = new CartPage();
+        var cartPage = new CartPage();
         cartPage.updateProductCountByName(productName, style, size, amount);
         for (Product product : storage.products)
         {
@@ -57,7 +57,7 @@ public void updateCountOfProduct(String productName, String size, String style,
     @Then("^I can remove \"([^\"]*)\" with \"([^\"]*)\" and \"([^\"]*)\"$")
     public void removeProduct(String productName, String size, String style)
     {
-        CartPage cartPage = new CartPage();
+        var cartPage = new CartPage();
         cartPage.removeProductByName(productName, style, size);
 
         storage.removeProduct(productName, style, size);

src/test/java/posters/cucumber/support/GlobalStorage.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.cucumber.support;
 
 import java.util.ArrayList;
@@ -38,7 +35,7 @@ public Product addProduct(Product product)
         // increase amount of product if already there or add the whole product
         if (products.contains(product))
         {
-            Product updatedProduct = products.get(products.indexOf(product));
+            var updatedProduct = products.get(products.indexOf(product));
             updatedProduct.setAmount(updatedProduct.getAmount() + 1);
             return updatedProduct;
         }
@@ -51,7 +48,7 @@ public Product addProduct(Product product)
 
     public void removeProduct(String productName, String style, String size)
     {
-        for (Product product : products)
+        for (var product : products)
         {
             if (product.getName().equals(productName) && product.getSize().equals(size)
                 && product.getStyle().equals(style))

src/test/java/posters/cucumber/support/HomePageSupport.java

@@ -10,7 +10,7 @@ public class HomePageSupport
     @Step("validate homepage")
     public void validateHomePage(String title)
     {
-        HomePage homePage = new HomePage();
+        var homePage = new HomePage();
         homePage.isExpectedPage();
         homePage.title.validateTitle(title);
         homePage.validateStructure();

src/test/java/posters/cucumber/support/OpenPageFlows.java

@@ -22,17 +22,15 @@ public static HomePage homepage()
         clearBrowserCookies();
         // open home page
         open(Neodymium.configuration().url());
-        HomePage homePage = new HomePage();
-        homePage.isExpectedPage();
-        return homePage;
+        return new HomePage().isExpectedPage();
     };
 
     @Given("^login page is loaded$")
     @Step("open login page")
     public static LoginPage loginPage()
     {
         // open login page and check for expected page
-        LoginPage loginPage = homepage().userMenu.openLogin();
+        var loginPage = homepage().userMenu.openLogin();
         loginPage.isExpectedPage();
         return loginPage;
     };
@@ -42,7 +40,7 @@ public static LoginPage loginPage()
     public static RegisterPage registerPage()
     {
         // open login page and check for expected page
-        RegisterPage registerPage = homepage().userMenu.openRegister();
+        var registerPage = homepage().userMenu.openRegister();
         registerPage.isExpectedPage();
         return registerPage;
     };

src/test/java/posters/cucumber/support/OrderSupport.java

@@ -33,24 +33,24 @@ public OrderSupport(GlobalStorage storage)
     @Given("^new user with \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\" is registered and logged in$")
     public void registerAndLogIn(String firstName, String lastName, String email, String password)
     {
-        RegisterPage registerPage = OpenPageFlows.registerPage();
+        var registerPage = OpenPageFlows.registerPage();
         registerPage.isExpectedPage();
         storage.user = new User(firstName, lastName, email, password);
         registerPage.sendRegisterForm(firstName, lastName, email, password, password);
-        LoginPage loginPage = registerPage.userMenu.openLogin();
+        var loginPage = registerPage.userMenu.openLogin();
         loginPage.isExpectedPage();
         loginPage.sendLoginform(email, password);
     }
 
     @Then("^all the products are to find in order history$")
     public void validateOrderInOrderHistory()
     {
-        AccountOverviewPage accountOverview = new HomePage().userMenu.openAccountOverview();
-        accountOverview.isExpectedPage();
-        OrderHistoryPage orderHistory = accountOverview.openOrderHistory();
+        var accountOverviewPage = new HomePage().userMenu.openAccountOverview();
+        accountOverviewPage.isExpectedPage();
+        var orderHistoryPage = accountOverviewPage.openOrderHistory();
         for (Product product : storage.products)
         {
-            orderHistory.validateContainsProduct(product);
+            orderHistoryPage.validateContainsProduct(product);
         }
     }
 
@@ -65,25 +65,25 @@ public void openProductPageAndAddItoTheCart(String productUrl, String size, Stri
     @When("I add this product with size \"([^\"]*)\" and style \"([^\"]*)\" to the cart$")
     public void addProductToCart(String size, String style)
     {
-        ProductdetailPage productPage = new ProductdetailPage();
-        productPage.setSize(size);
-        productPage.setStyle(style);
+        var productDetailPage = new ProductdetailPage();
+        productDetailPage.setSize(size);
+        productDetailPage.setStyle(style);
 
-        Product product = storage.addProduct(productPage.getProduct());
+        var product = storage.addProduct(productDetailPage.getProduct());
 
-        productPage.addToCart();
-        productPage.miniCart.openMiniCart();
-        productPage.miniCart.validateMiniCartByProduct(product);
+        productDetailPage.addToCart();
+        productDetailPage.miniCart.openMiniCart();
+        productDetailPage.miniCart.validateMiniCartByProduct(product);
     }
 
     @When("^I specify the shipping address \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\" and use it for billing$")
     public void openFillAndSendShippingFormUseForBilling(String name, String company, String address, String city, String state, String zip, String country)
     {
-        CartPage cartPage = new ProductdetailPage().miniCart.openCartPage();
+        var cartPage = new ProductdetailPage().miniCart.openCartPage();
         cartPage.isExpectedPage();
-        ShippingAddressPage shippingPage = cartPage.openShippingPage();
-        shippingPage.isExpectedPage();
-        shippingPage.sendShippingAddressForm(name, company, address, city, state, zip, country, true);
+        var shippingAddressPage = cartPage.openShippingPage();
+        shippingAddressPage.isExpectedPage();
+        shippingAddressPage.sendShippingAddressForm(name, company, address, city, state, zip, country, true);
         storage.shippingAddress = new Address(name, company, address, city, state, zip, country);
         storage.billingAddress = new Address(name, company, address, city, state, zip, country);
         new PaymentPage().isExpectedPage();
@@ -92,31 +92,31 @@ public void openFillAndSendShippingFormUseForBilling(String name, String company
     @When("^I enter payment data \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\", \"([^\"]*)\"$")
     public void fillAndSendPaymentForm(String name, String cardNumber, String month, String year)
     {
-        PaymentPage paymentPage = new PaymentPage();
+        var paymentPage = new PaymentPage();
         paymentPage.isExpectedPage();
-        PlaceOrderPage placeOrder = paymentPage.sendPaymentForm(cardNumber, name, month, year);
+        var placeOrderPage = paymentPage.sendPaymentForm(cardNumber, name, month, year);
         storage.creditcard = new CreditCard(name, cardNumber, "xxxx xxxx xxxx " + cardNumber.substring(12, 16), month, year);
-        placeOrder.isExpectedPage();
+        placeOrderPage.isExpectedPage();
     }
 
     @Then("^I see all the products in order overview$")
     public void validateContainsAllProductsWithCorrectPricesAndAmount()
     {
         double subtotal = 0.0;
-        PlaceOrderPage placeOrder = new PlaceOrderPage();
+        var placeOrderPage = new PlaceOrderPage();
         for (Product product : storage.products)
         {
-            placeOrder.validateContainsProduct(product);
+            placeOrderPage.validateContainsProduct(product);
             subtotal += product.getTotalPrice();
         }
-        placeOrder.validateSubtotal(PriceHelper.format(subtotal));
+        placeOrderPage.validateSubtotal(PriceHelper.format(subtotal));
     }
 
     @Then("^my shipping and billing addresses as well as payment data are displayed correctly")
     public void validateAddressesAndPaymentData()
     {
-        PlaceOrderPage placeOrder = new PlaceOrderPage();
-        placeOrder.validateAddressesAndPayment(storage.shippingAddress, storage.billingAddress, storage.creditcard);
+        var placeOrderPage = new PlaceOrderPage();
+        placeOrderPage.validateAddressesAndPayment(storage.shippingAddress, storage.billingAddress, storage.creditcard);
     }
 
     @Then("^my order is successfully placed$")

src/test/java/posters/cucumber/support/RegisterSupport.java

@@ -42,9 +42,9 @@ public void registerUserSetup()
     @Step("delete user flow")
     public LoginPage deleteUser()
     {
-        HomePage homePage = new HomePage();
+        var homePage = new HomePage();
         // ensure that the user is logged in
-        LoginPage loginPage;
+        var loginPage = new LoginPage();
         if (!homePage.userMenu.isLoggedIn())
         {
             loginPage = homePage.userMenu.openLogin();
@@ -54,23 +54,23 @@ public LoginPage deleteUser()
         // needed since there is a bug in posters
         if (homePage.miniCart.getTotalCount() > 0)
         {
-            CartPage cartPage = homePage.miniCart.openCartPage();
+            var cartPage = homePage.miniCart.openCartPage();
             while (cartPage.hasProductsInCart())
             {
                 cartPage.removeProduct(1);
             }
         }
 
         // goto account page
-        AccountOverviewPage accountOverviewPage = homePage.userMenu.openAccountOverview();
+        var accountOverviewPage = homePage.userMenu.openAccountOverview();
         accountOverviewPage.validateStructure();
 
         // goto personal data page
-        PersonalDataPage personalDataPage = accountOverviewPage.openPersonalData();
+        var personalDataPage = accountOverviewPage.openPersonalData();
         personalDataPage.validateStructure();
 
         // goto account deletion page
-        DeleteAccountPage deleteAccountPage = personalDataPage.openDeleteAccount();
+        var deleteAccountPage = personalDataPage.openDeleteAccount();
         deleteAccountPage.validateStructure();
 
         // delete the account
@@ -88,9 +88,9 @@ public LoginPage deleteUser()
 
     public static LoginPage registerUser(User user)
     {
-        RegisterPage registerPage = OpenPageFlows.registerPage();
+        var registerPage = OpenPageFlows.registerPage();
         registerPage.isExpectedPage();
-        LoginPage loginPage = registerPage.sendRegisterForm(user, user.getPassword());
+        var loginPage = registerPage.sendRegisterForm(user, user.getPassword());
         loginPage.isExpectedPage();
 
         return loginPage;
@@ -100,7 +100,7 @@ public static LoginPage registerUser(User user)
     @Step("set up user and register him")
     public void registerUser(String firstName, String lastName, String email, String password)
     {
-        RegisterPage registerPage = new RegisterPage();
+        var registerPage = new RegisterPage();
         registerPage.isExpectedPage();
         storage.user = new User(firstName, lastName, email, password);
         registerPage.sendRegisterForm(firstName, lastName, email, password, password);

src/test/java/posters/dataobjects/Address.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.dataobjects;
 
 /**

src/test/java/posters/dataobjects/CreditCard.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.dataobjects;
 
 /**

src/test/java/posters/dataobjects/Product.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.dataobjects;
 
 import com.xceptance.neodymium.util.Neodymium;

src/test/java/posters/dataobjects/User.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.dataobjects;
 
 /**

src/test/java/posters/pageobjects/components/CheckoutHeader.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.pageobjects.components;
 
 import static com.codeborne.selenide.Condition.exist;

src/test/java/posters/pageobjects/components/MiniCart.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package posters.pageobjects.components;
 
 import static com.codeborne.selenide.Condition.exactText;
@@ -115,14 +112,14 @@ public void validateSubtotal(String subtotal)
      * @param product
      */
 
-    @Step("validate \"{product}\" in the mini cart")
+    @Step("validate '{product}' in the mini cart")
     public void validateMiniCart(int position, Product product)
     {
         validateMiniCart(position, product.getName(), product.getStyle(), product.getSize(), product.getAmount(),
                          PriceHelper.format(product.getTotalPrice()));
     }
 
-    @Step("validate \"{product}\" in the mini cart by name")
+    @Step("validate '{product}' in the mini cart by name")
     public void validateMiniCartByProduct(Product product)
     {
         SelenideElement productContainer = $$(".cartItems").filter(matchText(product.getCartRowRegex())).shouldHaveSize(1).first();
@@ -140,7 +137,7 @@ public void validateMiniCartByProduct(Product product)
      * @param productAmount
      * @param productTotalPrice
      */
-    @Step("validate \"{product}\" in the mini cart")
+    @Step("validate '{product}' in the mini cart")
     public void validateMiniCart(int position, Product product, int productAmount, String productTotalPrice)
     {
         validateMiniCart(position, product.getName(), product.getStyle(), product.getSize(), productAmount, productTotalPrice);

src/test/java/posters/pageobjects/components/Search.java

@@ -20,21 +20,21 @@ public void isComponentAvailable()
         searchField.should(exist);
     }
 
-    @Step("search for \"{searchTerm}\" without result")
+    @Step("search for '{searchTerm}' without result")
     public NoHitsPage noResult(String searchTerm)
     {
         search(searchTerm);
         return new NoHitsPage();
     }
 
-    @Step("search for \"{searchTerm}\" with result")
+    @Step("search for '{searchTerm}' with result")
     public CategoryPage categoryPageResult(String searchTerm)
     {
         search(searchTerm);
         return new CategoryPage();
     }
 
-    @Step("search for \"{searchTerm}\"")
+    @Step("search for '{searchTerm}'")
     public void search(String searchTerm)
     {
         openSearch();

src/test/java/posters/pageobjects/components/SuccessMessage.java

@@ -18,7 +18,7 @@ public void isComponentAvailable()
         successMessage.should(exist);
     }
 
-    @Step("validate that the success message \"{message}\" is visible")
+    @Step("validate that the success message '{message}' is visible")
     public void validateSuccessMessage(String message)
     {
         // Wait until javascript makes the success message visible