Updates for scipy, numpy 2, and Python 3.12 #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lneuhaus
changed the title
lneuhaus
commented
May 13, 2025
lneuhaus
commented
May 13, 2025
…berryfields into updates-for-scipy-2
heltluke
reviewed
May 14, 2025
heltluke
reviewed
May 14, 2025
heltluke
reviewed
May 14, 2025
heltluke
reviewed
May 14, 2025
heltluke
reviewed
May 14, 2025
heltluke
reviewed
May 14, 2025
lneuhaus
commented
May 15, 2025
lneuhaus
commented
May 15, 2025
lneuhaus
commented
May 15, 2025
Co-authored-by: Luke Helt <[email protected]>
lneuhaus
commented
May 16, 2025
lneuhaus
commented
May 16, 2025
heltluke
reviewed
May 16, 2025
| @@ -1,15 +1,15 @@ | |||
| networkx==2.7.1 | |||
| numba==0.55.1 | |||
| numpy==1.21.5 | |||
| numpy==1.26.4 | |||
There was a problem hiding this comment.
Shouldn't this be further along?
There was a problem hiding this comment.
no clue really. I guess we could manually bump it, but also I suspect dependabot will do it for us?
There was a problem hiding this comment.
It's just the == that concerns me. I would manually replace all of the versions here with whatever gets installed via setup.py.
heltluke
approved these changes
May 16, 2025
heltluke
reviewed
May 16, 2025
|
Reverted some cosmetic changes, just to make this PR touch fewer files. I think we could easily run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
scipyupdated to version1.14.0on June 24, 2024, and made some breaking changes to their API.Description of the Change:
This PR updates
scipy.integrate.simpstoscipy.integrate.simpsonwhen using newer scipy versions, such that things continue working. It is also explicit about the creation of raggednumpyarrays. It furthermore fixes a number of CI issues, to get most test pipelines passing again.Benefits:
Get all the latest features and bugfixes in newer
scipy.Possible Drawbacks:
N/A
Related GitHub Issues:
N/A