-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update installation supported OSes #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mDuo13
wants to merge
4
commits into
master
Choose a base branch
from
update_install_docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+90
−604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequdev
reviewed
Jul 14, 2025
maria-robobug
previously approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some very minor comments, LGTM!
docs/infrastructure/installation/update-rippled-manually-on-ubuntu.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Maria Shodunke <[email protected]>
amarantha-k
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approving updates made after original approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content updates
Updating, cleaning up, or rewriting existing content for better usability or new contexts
infra
Server configuration, validation, infrastructure, peer-to-peer network details
needs japanese translation
PRs with English changes that need to be added/updated in the Japanese translation of the site
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$
from some commandline instructions. People like to copy-paste instructions and this breaks that without adding clarity, so we've moved away from including$
in shell examples (unless the example includes both the command and response, in which case the$
helps to distinguish which is which).rippled
Reporting Mode #2957 - doesn't fully fix though)I made minimal updates to some Japanese-translated files to fix some broken links and remove reference to the deleted diagram, but this will still need a more thorough update to the Japanese translations.
Aside: I tried making the "Installation" landing page look nicer (for example, by using the
{% xrpl-card %}
macro that's used on the References landing page or by using a table) but I wasn't satisfied with any of the results so I decided to set aside those improvements (#2256) for another time.