Skip to content

Update dependencies & fix some bugs in JS code #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025
Merged

Update dependencies & fix some bugs in JS code #3049

merged 4 commits into from
Apr 17, 2025

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Mar 25, 2025

  • Updates Realm to v0.120.2 which contains a number of fixes including some security issues among dependencies. It was supposed to contain a fix for interactive tutorials, but it turns out that fix was incomplete. Redocly has confirmed they've reproduced the bug and are working on a fix. But for now we can update to satisfy dependabot.
  • Updated the "Issue a Fungible Token" tutorial to match the updated format for the Testnet faucet's response format. (The faucet no longer tells you your current balance, just the amount that it sent you.) The "Issue a Fungible Token" interactive tutorial works in local dev mode now if you navigate to it from another page, but (due to the aforementioned Redocly bug) not if you load it directly.
  • Updates the Transaction Sender dev tool for the current version of xrpl.js which uses the rippled API v2 by default. Prior to this fix, the tool would fail to send an EscrowFinish transaction because it was looking in the old place for the Sequence field.

@mDuo13 mDuo13 added bug Typo or other small documentation error tokenization Relating to fungible or non-fungible token functionality redocly Issues with the Redocly toolchain labels Mar 25, 2025
Copy link

socket-security bot commented Mar 25, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@redocly/[email protected] ⏵ 0.120.297 +210072 +1100100
Added[email protected]10010010077100
Updated[email protected] ⏵ 5.8.3100 +110089 +1100100

View full report ↗

@mDuo13 mDuo13 changed the title Update dependencies & try to fix Issue a Fungible Token tutorial Update dependencies & fix some bugs in JS code Apr 11, 2025
@mDuo13 mDuo13 marked this pull request as ready for review April 11, 2025 17:54
@mDuo13
Copy link
Collaborator Author

mDuo13 commented Apr 11, 2025

Rebased on master and added a couple more fixes and updates. Even though the interactive tutorials bug isn't fixed, I believe we should push this sooner to incorporate other updates.

@mDuo13 mDuo13 added the dependencies Pull requests that update a dependency file label Apr 11, 2025
@@ -77,7 +77,7 @@ async function onClickCreateEscrow(
}
setEscrowWidthPercent(0)

if(escrowCreateResponse.result.Sequence === undefined) {
if(escrowCreateResponse.result.tx_json.Sequence === undefined) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relatedly - maybe we can link to https://github.com/xrplf/rippled/blob/4ba9288/API-CHANGELOG.md#modifications-to-json-transaction-element-in-v2 somewhere? This is where we "documented" the change

@mDuo13 mDuo13 merged commit d322370 into master Apr 17, 2025
5 of 6 checks passed
@mDuo13 mDuo13 deleted the realm_update branch April 17, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Typo or other small documentation error dependencies Pull requests that update a dependency file redocly Issues with the Redocly toolchain tokenization Relating to fungible or non-fungible token functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants