-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update dependencies & fix some bugs in JS code #3049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.
|
Rebased on master and added a couple more fixes and updates. Even though the interactive tutorials bug isn't fixed, I believe we should push this sooner to incorporate other updates. |
@@ -77,7 +77,7 @@ async function onClickCreateEscrow( | |||
} | |||
setEscrowWidthPercent(0) | |||
|
|||
if(escrowCreateResponse.result.Sequence === undefined) { | |||
if(escrowCreateResponse.result.tx_json.Sequence === undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relatedly - maybe we can link to https://github.com/xrplf/rippled/blob/4ba9288/API-CHANGELOG.md#modifications-to-json-transaction-element-in-v2 somewhere? This is where we "documented" the change
Sequence
field.