Skip to content

Rippling redux#2856

Merged
DennisDawson merged 9 commits intomasterfrom
update_rippling
Jan 21, 2025
Merged

Rippling redux#2856
DennisDawson merged 9 commits intomasterfrom
update_rippling

Conversation

@DennisDawson
Copy link
Copy Markdown
Contributor

Streamline the Rippling topic for clarity.

Streamline the Rippling topic for clarity.
@tequdev tequdev added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Nov 19, 2024
@DennisDawson DennisDawson marked this pull request as ready for review December 3, 2024 21:13
@amarantha-k amarantha-k requested review from mDuo13 and maria-robobug and removed request for oeggert December 17, 2024 20:20
Comment thread docs/concepts/tokens/fungible-tokens/rippling.md Outdated
Comment on lines +32 to +34
Rippling can involve several accounts as the XRPL server finds a path to transfer the funds. For example, the funds might flow between two issuer accounts that have a trust line between them.

For example:
[![Holder A transfers currency through Issuers A and B to get to Holder B.](/docs/img/cpt-rippling5.png "Holder A transfers currency through Issuers A and B to get to Holder B.")](/docs/img/cpt-rippling5.png)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing wrong with this scenario, but I think a more important scenario to illustrate is the one where rippling flows through a holder of both issuers' tokens, as shown in the original diagram #3. Laid out like you have the others, the diagram would be shaped kind of like an "M" (or upside-down-W).

One little detail that the current diagram elides is that Holder A is sending "USD issued by issuer A" and Holder B is receiving "USD issued by issuer B"—technically two different tokens which can have different properties like transfer fees, even though they have the same currency code (rippling can only occur if the currency code is the same). In my experience, this simplification tends to confuse people, who think that all USD issued in the XRPL is the same. So it might be worth adding that detail to the diagram somehow. Conventionally, we've written "USD.issuerA" to represent this type of thing.

Comment thread docs/concepts/tokens/fungible-tokens/rippling.md Outdated
Comment thread docs/concepts/tokens/fungible-tokens/rippling.md Outdated
Comment thread docs/concepts/tokens/fungible-tokens/rippling.md
Comment thread docs/concepts/tokens/fungible-tokens/rippling.md Outdated
Comment thread docs/concepts/tokens/fungible-tokens/rippling.md
Comment thread docs/concepts/tokens/fungible-tokens/rippling.md Outdated
DennisDawson and others added 5 commits December 18, 2024 10:48
Co-authored-by: Rome Reginelli <rome@ripple.com>
Co-authored-by: Rome Reginelli <rome@ripple.com>
Co-authored-by: Rome Reginelli <rome@ripple.com>
Forgot to change the balance for the sender and receiver.
mDuo13
mDuo13 previously approved these changes Dec 20, 2024
Copy link
Copy Markdown
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the changes, with one important note on terminology.

Tokens might also flow through intermediary gateway accounts to reach a holder.

[{% inline-svg file="/docs/img/noripple-05.svg" /%}](/docs/img/noripple-05.svg "Charlie --($10)-- Institution A --($1, No Ripple)-- Emily --($100, No Ripple)-- Institution B --($2)-- Daniel")
[![Holder A transfers tokens through Issuers A and B and Gateway X to get to Holder B.](/docs/img/cpt-rippling6.png "Holder A transfers tokens through Issuers A and B and Gateway X to get to Holder B.")](/docs/img/cpt-rippling6.png)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that using the term "gateway" here will confuse people who come across legacy content that uses the term "gateway" differently. From 2013-2016 or so the term "gateway" was widely used in the XRPL community and in Ripple's communications to mean, essentially, "stablecoin issuer."

Perhaps "intermediary" is better here (and in the diagram) to dodge that confusion. The key thing here is that the intermediary is also just an ordinary holder except they allow rippling, not necessarily a special business or anything.

Copy link
Copy Markdown
Contributor Author

@DennisDawson DennisDawson Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a wider discussion on this - I agree that we need a term for an account that allows rippling but is not an issuer. I want to make it clear that Holders never allow rippling, Exchanges allow rippling, and Issuers allow rippling, then document the basic configurations for each of those accounts. We can pick the term for the intermediary/exchange user after the holidays.

@DennisDawson DennisDawson merged commit f60f1d6 into master Jan 21, 2025
@DennisDawson DennisDawson deleted the update_rippling branch January 21, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants