Skip to content

DRAFT: Refactor the sendMulti functions into a common method with callbacks #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ximinez wants to merge 4 commits into
base: ximinez/lending-XLS-66-ongoing
Choose a base branch
from
Draft

DRAFT: Refactor the sendMulti functions into a common method with callbacks #6132

ximinez wants to merge 4 commits into from

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Dec 10, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@ximinez
Refactor the sendMulti functions into a common method with callbacks
28c3211
@ximinez
Merge remote-tracking branch 'XRPLF/ximinez/lending-XLS-66-ongoing' i…
94df21a 
…nto ximinez/lending-sendmulti

* XRPLF/ximinez/lending-XLS-66-ongoing:
  Update rippled to xrpl
  Change some instances of View info() to header()
  Update rippled to xrpl
  refactor: Rename `ripple` namespace to `xrpl` (5982)
  refactor: Move JobQueue and related classes into xrpl.core module (6121)
  refactor: Rename `rippled` binary to `xrpld` (5983)
  refactor: rename info() to header() (6138)
  refactor: rename `LedgerInfo` to `LedgerHeader` (6136)
  refactor: clean up `RPCHelpers` (5684)
  chore: Fix docs readme and cmake (6122)
  chore: Clean up .gitignore and .gitattributes (6001)
  chore: Use updated secp256k1 recipe (6118)
@ximinez
Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-se…
7246547 
…ndmulti
@ximinez
Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-se…
e1b9e6f 
…ndmulti
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ximinez