Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Dec 10, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.5%. Comparing base (881087d) to head (db758c5).

Files with missing lines Patch % Lines
src/xrpld/app/wasm/detail/HostFuncImpl.cpp 84.2% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           ripple/wasmi-host-functions   #6131     +/-   ##
=============================================================
- Coverage                         79.5%   79.5%   -0.0%     
=============================================================
  Files                              848     848             
  Lines                            73417   73432     +15     
  Branches                          8401    8423     +22     
=============================================================
- Hits                             58387   58366     -21     
- Misses                           15030   15066     +36     
Files with missing lines Coverage Δ
src/xrpld/app/wasm/detail/HostFuncImpl.cpp 99.0% <84.2%> (-1.0%) ⬇️

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pwang200
Copy link
Collaborator

Look good to me, but Olek should take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants