-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Limit reply size on TMGetObjectByHash queries #6110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pratikmankawde
wants to merge
14
commits into
develop
Choose a base branch
from
pratik/Charge-higher-fees-for-and-reject-heavy-TMGetObjectByHash-queries
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−3
Open
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0eb0495
first draft
pratikmankawde 75d06cc
Merge branch 'develop' into pratik/Charge-higher-fees-for-and-reject-…
pratikmankawde 3252666
cleanup
pratikmankawde d657bab
Merge branch 'develop' into pratik/Charge-higher-fees-for-and-reject-…
pratikmankawde 138e8ea
removed amendment changes
pratikmankawde e9b5dcb
added limit to reply size
pratikmankawde f6fff80
minor clean-up
pratikmankawde 7dddc90
Merge branch 'develop' into pratik/Charge-higher-fees-for-and-reject-…
pratikmankawde e3d76f2
Merge branch 'develop' into pratik/Charge-higher-fees-for-and-reject-…
pratikmankawde 84fa3ae
subscription test was failing, so trying with longer timeout,
pratikmankawde 6290af1
Update src/xrpld/overlay/detail/PeerImp.cpp
pratikmankawde 5f912ec
Update src/xrpld/overlay/detail/PeerImp.cpp
pratikmankawde 5c3ae67
Merge branch 'develop' into pratik/Charge-higher-fees-for-and-reject-…
pratikmankawde 58b6258
Merge branch 'develop' into pratik/Charge-higher-fees-for-and-reject-…
pratikmankawde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1351,8 +1351,8 @@ | |
| { | ||
| // If we've never been in synch, there's nothing we can do | ||
| // with a transaction | ||
| JLOG(p_journal_.debug()) << "Ignoring incoming transaction: " | ||
| << "Need network ledger"; | ||
| JLOG(p_journal_.debug()) | ||
| << "Ignoring incoming transaction: " << "Need network ledger"; | ||
pratikmankawde marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return; | ||
| } | ||
|
|
||
|
|
@@ -2618,6 +2618,13 @@ | |
| newObj.set_ledgerseq(obj.ledgerseq()); | ||
|
|
||
| // VFALCO NOTE "seq" in the message is obsolete | ||
|
|
||
| // Check if by adding this object, reply has reached its | ||
| // limit | ||
| if (reply.objects_size() == Tuning::hardMaxReplyNodes) | ||
|
||
| { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.