-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Check permissions in LoanSet and LoanPay #6108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ximinez
merged 11 commits into
ximinez/lending-XLS-66-ongoing
from
a1q123456/pay-fee-into-the-pseudo-account-if-broker-removes-trustline-or-mpt
Dec 17, 2025
Merged
Check permissions in LoanSet and LoanPay #6108
ximinez
merged 11 commits into
ximinez/lending-XLS-66-ongoing
from
a1q123456/pay-fee-into-the-pseudo-account-if-broker-removes-trustline-or-mpt
Dec 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e73f1c6 to
6bec1f0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ximinez/lending-XLS-66-ongoing #6108 +/- ##
================================================================
- Coverage 79.1% 79.1% -0.0%
================================================================
Files 839 839
Lines 71384 71385 +1
Branches 8310 8313 +3
================================================================
- Hits 56487 56485 -2
- Misses 14897 14900 +3
🚀 New features to boost your workflow:
|
6bec1f0 to
5e0a0cb
Compare
Collaborator
Author
|
Let me add a new test case for it. Making it a draft temporarily. |
Collaborator
Author
|
Actually, let me convert this pr to a draft again for a similar fix. |
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
1468299 to
5dccd89
Compare
Tapanito
reviewed
Dec 10, 2025
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
ximinez
requested changes
Dec 10, 2025
Co-authored-by: Ed Hennis <[email protected]>
Signed-off-by: JCW <[email protected]>
Signed-off-by: JCW <[email protected]>
ximinez
approved these changes
Dec 17, 2025
…into-the-pseudo-account-if-broker-removes-trustline-or-mpt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)