-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Disallow pseudo accounts to be Destination for LoanBrokerCoverWithdraw #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ximinez/lending-XLS-66-ongoing
Are you sure you want to change the base?
Disallow pseudo accounts to be Destination for LoanBrokerCoverWithdraw #6106
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ximinez/lending-XLS-66-ongoing #6106 +/- ##
==============================================================
Coverage 79.1% 79.1%
==============================================================
Files 839 839
Lines 71355 71373 +18
Branches 8328 8320 -8
==============================================================
+ Hits 56426 56462 +36
+ Misses 14929 14911 -18
🚀 New features to boost your workflow:
|
shawnxie999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: JCW <[email protected]>
9e0b4e8 to
31b48e3
Compare
ximinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very small request
Co-authored-by: Ed Hennis <[email protected]>
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)