Skip to content

Conversation

@a1q123456
Copy link
Collaborator

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (354531f) to head (8fb4a65).
⚠️ Report is 34 commits behind head on ximinez/lending-XLS-66-ongoing.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           ximinez/lending-XLS-66-ongoing   #6106   +/-   ##
==============================================================
  Coverage                            79.1%   79.1%           
==============================================================
  Files                                 839     839           
  Lines                               71355   71373   +18     
  Branches                             8328    8320    -8     
==============================================================
+ Hits                                56426   56462   +36     
+ Misses                              14929   14911   -18     
Files with missing lines Coverage Δ
include/xrpl/ledger/View.h 100.0% <ø> (ø)
...rc/xrpld/app/tx/detail/LoanBrokerCoverWithdraw.cpp 96.3% <100.0%> (+0.1%) ⬆️

... and 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ximinez ximinez changed the base branch from develop to ximinez/lending-XLS-66-ongoing December 4, 2025 17:39
Signed-off-by: JCW <[email protected]>
@a1q123456 a1q123456 force-pushed the a123456/disallow-dest-to-be-a-pseudo-account branch from 9e0b4e8 to 31b48e3 Compare December 5, 2025 09:27
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very small request

@a1q123456 a1q123456 requested a review from ximinez December 10, 2025 23:08
@ximinez ximinez enabled auto-merge (squash) December 17, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants